Fix AcInstrDecodeTest>>testPowerAddiSymbolic
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this line: self assert: (instr fieldValue: 'd') equals: 'x' the "instr fieldValue: 'd'" is a Z3Int, so the #= down in #assert:equals: coerces the 'x' to a Z3Int. So now we have two 'x' symbols: a BV16 'x' and an Int 'x', which are not necessarily equal. The correct thing to do is to start from the same BV 'x', and compare the Int interpretation of `d` to the signed Int interpretation of 'x'.
shingarov
force-pushed
the
fix-addi-symbolic
branch
from
5f885cd
to
edb6ba1
Compare
Neither do I, not yet. But this is worth investigating... |
It did pass before MA commit shingarov/MachineArithmetic@216a5c8. This is because the before that, in The problem is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivial push yesterday (classifying a method) re-triggered CI and now https://github.com/shingarov/Pharo-ArchC/actions/runs/9171675951/job/25216516144 . I don't understand how this could possibly pass before.