Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AcInstrDecodeTest>>testPowerAddiSymbolic #36

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fix AcInstrDecodeTest>>testPowerAddiSymbolic #36

merged 2 commits into from
Jun 19, 2024

Commits on May 22, 2024

  1. Fix obviously incorrect assembly in comment

    @shingarov
    shingarov committed May 22, 2024
    Configuration menu
    Copy the full SHA
    82015e2 View commit details
    Browse the repository at this point in the history

  2. Use correct sort for x in #testPowerAddiSymbolic 

    In this line:

self assert: (instr fieldValue: 'd') equals: 'x'

the "instr fieldValue: 'd'" is a Z3Int, so the #= down in #assert:equals:
coerces the 'x' to a Z3Int.  So now we have two 'x' symbols: a BV16 'x'
and an Int 'x', which are not necessarily equal.
The correct thing to do is to start from the same BV 'x',
and compare the Int interpretation of `d` to the signed Int
interpretation of 'x'.
    @shingarov
    shingarov committed May 22, 2024
    Configuration menu
    Copy the full SHA
    edb6ba1 View commit details
    Browse the repository at this point in the history