Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Z3Solver >> #release instead of #del #37

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

janvrany
Copy link
Collaborator

MA commit cceedbd removed #del in favor of #release. This commit catches up to use the latter.

MA commit cceedbd removed `#del` in favor of `#release`. This commit
catches up to use the latter.
@janvrany janvrany requested a review from shingarov June 19, 2024 13:30
@janvrany
Copy link
Collaborator Author

CI fails because

    self assert: constituents size equals: 3.

fails. That's because encoding is BV32:(concat (concat (concat #b000011 to) #b01100) #x3039).
Indeed, encoding simplify yields BV32:(concat #b000011 to #b011000011000000111001)

@shingarov Do you recall, did we change something in MA that drops that simplify somewhere?

@shingarov
Copy link
Owner

So merging #36 did NOT fix CI. Actually I would be surprised if it did. ArchC is massively broken at this point; I need to dedicate some love to it.

did we change something in MA that drops that simplify somewhere?

We absolutely did, as part of the PLE chain of commits. That simplify is a very deep rabbit hole. I believe its investigation is blocked by integrating Nikolaj's fix to "wrong arity". Which is blocked by Settings (or what was that thing called). Which, IIRC, was blocked by Ref Counting (or was it?)

@janvrany
Copy link
Collaborator Author

We absolutely did, as part of the PLE chain of commits.

Ah, of course, thanks!

@janvrany
Copy link
Collaborator Author

ArchC is massively broken at this point; I need to dedicate some love to it.

Let's delay this a a bit before having a conversation about it. There're a number of cases where the current design make things bit awkward.

@shingarov shingarov merged commit ed20e30 into shingarov:pure-z3 Jun 24, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants