Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes for 3.4.9 release #1162

Open
wants to merge 44 commits into
base: linux-release-3.4.9
Choose a base branch
from

Conversation

shiftkey
Copy link
Owner

@shiftkey shiftkey commented Nov 11, 2024

Closes #1155

Description

  • CI passes
  • Update to latest electron patch release
  • Diff makes sense
  • Packages all work
  • Can install and run app locally

shiftkey and others added 30 commits November 11, 2024 11:20
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
* drop old icon used in app window
* regenerate smaller icons from new 256px source
…ration easier (#555 #558)

Co-Authored-By: nullrequest <30698906+advaithm@users.noreply.github.com>
Co-authored-by: Brendan Forster <github@brendanforster.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
… architectures (#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898)

Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
shiftkey and others added 10 commits November 11, 2024 11:20
Co-authored-by: Brendan Forster <github@brendanforster.com>
Bumps [electron-packager](https://github.com/electron/electron-packager) from 17.1.1 to 17.1.2.
- [Release notes](https://github.com/electron/electron-packager/releases)
- [Changelog](https://github.com/electron/electron-packager/blob/main/NEWS.md)
- [Commits](electron/packager@v17.1.1...v17.1.2)

---
updated-dependencies:
- dependency-name: electron-packager
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [yaml](https://github.com/eemeli/yaml) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v2.5.0...v2.6.0)

---
updated-dependencies:
- dependency-name: yaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1138 #1141)

Bumps [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder) from 24.13.3 to 25.1.8.
- [Release notes](https://github.com/electron-userland/electron-builder/releases)
- [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md)
- [Commits](https://github.com/electron-userland/electron-builder/commits/v25.1.8/packages/electron-builder)

---
updated-dependencies:
- dependency-name: electron-builder
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1121 #1130 #1132)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.1.0 to 7.0.5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6.1.0...v7.0.5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
@shiftkey shiftkey marked this pull request as ready for review February 4, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants