Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GPG public key file to use .gpg extension #839

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Rename GPG public key file to use .gpg extension #839

merged 1 commit into from
Feb 22, 2023

Conversation

phanect
Copy link

@phanect phanect commented Feb 21, 2023

#834

(I avoid Closes keyword this time)

Description

Some versions of apt may assume that any .asc key is ASCII-armored. Therefore, if GPG public key has .asc extension, some errors raised on apt update and you cannot install github-desktop.

W: GPG error: https://apt.packages.shiftkey.dev/ubuntu any InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 7FC979028B1997C1
E: The repository 'https://apt.packages.shiftkey.dev/ubuntu any InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

By changing the extension, this error is not raised.

See: #834 (comment)

Screenshots

N/A

Release notes

Notes:

Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the assistance with digging into this issue!

@shiftkey shiftkey merged commit b9e856a into shiftkey:linux Feb 22, 2023
theofficialgman pushed a commit to theofficialgman/desktop that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants