Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh smaller icons to use new theme #530

Merged
merged 3 commits into from
Jul 6, 2021
Merged

refresh smaller icons to use new theme #530

merged 3 commits into from
Jul 6, 2021

Conversation

shiftkey
Copy link
Owner

Fixes #518

The smaller icons under app/static/icons/were added in #395, but are not used in macOS and Windows, so they didn't get the refresh in desktop#11388

I simply downscaled the 256x256px version to fit and verify the issue, but if someone more skilled with image manipulation wants to refine these please submit a PR.

cc @ivoxavier @Mrlinkwii who commented on #518

Before

This is where the old icon continued to be visible for me, which is different to the original issue.

After

Yep, not my finest work, so happy to leave this open if someone wants to have a better go at downscaling the source material.

@shiftkey shiftkey force-pushed the use-standard-icons branch 2 times, most recently from 3d23294 to e48f88a Compare June 30, 2021 17:12
@shiftkey shiftkey marked this pull request as ready for review June 30, 2021 17:13
@shiftkey shiftkey force-pushed the linux branch 3 times, most recently from 6869050 to 56a5378 Compare July 3, 2021 17:39
@shiftkey shiftkey force-pushed the use-standard-icons branch from e48f88a to b1fcd35 Compare July 6, 2021 19:01
@shiftkey shiftkey merged commit 76ad8c7 into linux Jul 6, 2021
@shiftkey shiftkey deleted the use-standard-icons branch July 6, 2021 19:24
shiftkey added a commit that referenced this pull request Jul 14, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
6c9a491 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
@shiftkey shiftkey mentioned this pull request Jul 19, 2021
Closed
shiftkey added a commit that referenced this pull request Jul 19, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
1bb90b2 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
@shiftkey shiftkey mentioned this pull request Jul 19, 2021
Merged
shiftkey added a commit that referenced this pull request Jul 22, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
3077f33 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 13, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
31541d3 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 14, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
dfeac86 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 20, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
91c5e75 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 24, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
d00e395 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 24, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
2157134 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 24, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
ed0faf2 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 24, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
9c4b9d6 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 24, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
35533c7 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 24, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
02fdcf2 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Aug 29, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
efd554f 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey added a commit that referenced this pull request Sep 1, 2021
@shiftkey
refresh smaller icons to use new theme (#530)
1a8d742 
* drop explicit window icon on Linux
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Aug 14, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
153b9fc 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Aug 15, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
cb0f39b 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Aug 17, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
f640171 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Aug 17, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
82ecec3 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Sep 2, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
eac196f 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Sep 2, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
1a45bc4 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Oct 30, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
33cc3dd 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
eb4580d 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
6e8ecfd 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
ccb02c2 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
c1fbcc4 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 8, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
fbdb1e8 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
c8a2584 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
a48b064 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
f74008c 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
3227a23 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
2631ec6 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
a2e914b 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
64ace18 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Nov 11, 2024
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
4c08c39 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
da7d76b 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
9a4f749 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
2639594 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
db2330a 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 5, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
20fcef9 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
8e8382c 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
a179b02 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
8bc58a9 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
37e4e77 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
shiftkey pushed a commit that referenced this pull request Feb 9, 2025
@kevinhikaruevans @shiftkey
fix: add smaller icons and align with new theme (#395 #530 #561)
c4cafea 
* drop old icon used in app window
* regenerate smaller icons from new 256px source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Desktop icon still get's loaded in new GitHub Desktop versions
1 participant
@shiftkey