-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shentu prefix revoke certificate #754
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## shentu-prefix #754 +/- ##
=================================================
+ Coverage 47.43% 47.75% +0.31%
=================================================
Files 130 130
Lines 12671 12671
=================================================
+ Hits 6011 6051 +40
+ Misses 6079 6034 -45
- Partials 581 586 +5
|
@@ -75,7 +75,7 @@ func (k msgServer) RevokeCertificate(goCtx context.Context, msg *types.MsgRevoke | |||
revokeEvent := sdk.NewEvent( | |||
types.EventTypeRevokeCertificate, | |||
sdk.NewAttribute("revoker", msg.Revoker), | |||
sdk.NewAttribute("revoked_certificate", certificate.String()), | |||
sdk.NewAttribute("revoked_certificate", certificate.ToString()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a format error in the previous pb string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* change address prefix to shentu * Migrate shield (#738) * migrate shield certik prefix to shentu * migrate shield certik prefix to shentu * migrate shield certik prefix to shentu * migrate shield stored prefix to shentu * sort import files * update ConsensusVersion * update pool migration * change v280 to v4 * add v4_test package * migrate oracle certik prefix to shentu (#740) * migrate oracle certik prefix to shentu * update ConsensusVersion * update operator migration * add oracle withdraw migration * sort imports * change v280 to v3 * add v3 * migrate cert stored prefix to shentu (#739) * migrate cert stored prefix to shentu * sort import files * update ConsensusVersion * add cert library migration * change v280 to v2 * migrate certificate.content * [prefix-trans]migrate store for staking, gov and feegrant (#747) * initially add staking store migration * finish store migration for staking * add store migration for feegrant and gov * add unit test * fix feegrant unit test * fix lint * using cosmos sdk 0.45.11-3 * add negative tests * change impl for feegrant * simplify code * Store migration for slashing, auth and authz (#746) * Store migration for slashing, auth and authz --------- Co-authored-by: zheng-bin <wenwubinzheng@gmail.com> * skip empty certificate's proposer (#749) add v3 * change migration certificate MustMarshalLengthPrefixed function to M… (#750) * change migration certificate MustMarshalLengthPrefixed function to MustMarshal function * change migration certificate MustMarshalLengthPrefixed function to MustMarshal function * Shentu prefix revoke certificate (#754) * fix revoke-certificate, platform cmd * fix revoke-certificate, platform cmd * fix revoke-certificate, platform cmd * Replace certik word (#752) * replace shentu * change to shentu word * change to shentu word * replace to shentu * add address prefix conversion for specific gov proposal content (#758) * add address conversion for specific proposal contens * add more negative test --------- Co-authored-by: haozhan9 <zhanghao_tt@sina.com> Co-authored-by: zheng-bin <wenwubinzheng@gmail.com>
Closes: #XXX
Related: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)