Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate shield #738

Merged
merged 9 commits into from
Aug 4, 2023
Merged

Migrate shield #738

merged 9 commits into from
Aug 4, 2023

Conversation

kevin-yuhh
Copy link
Contributor

@kevin-yuhh kevin-yuhh commented Jul 24, 2023

Closes: #721
Related: #721

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@kevin-yuhh kevin-yuhh requested a review from a team as a code owner July 24, 2023 01:44
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #738 (43c9046) into shentu-prefix (725de9b) will increase coverage by 0.29%.
The diff coverage is 65.93%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           shentu-prefix     #738      +/-   ##
=================================================
+ Coverage          46.54%   46.83%   +0.29%     
=================================================
  Files                126      127       +1     
  Lines              11905    12087     +182     
=================================================
+ Hits                5541     5661     +120     
- Misses              5871     5913      +42     
- Partials             493      513      +20     
Files Changed Coverage Δ
x/shield/keeper/migrations.go 22.22% <0.00%> (-6.35%) ⬇️
x/shield/legacy/v4/store.go 66.66% <66.66%> (ø)

Copy link
Contributor

@skyargos skyargos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-yuhh kevin-yuhh merged commit 3b14d35 into shentu-prefix Aug 4, 2023
17 checks passed
@kevin-yuhh kevin-yuhh deleted the migrate-shield branch August 4, 2023 06:56
kevin-yuhh added a commit that referenced this pull request Aug 24, 2023
* change address prefix to shentu

* Migrate shield (#738)

* migrate shield certik prefix to shentu

* migrate shield certik prefix to shentu

* migrate shield certik prefix to shentu

* migrate shield stored prefix to shentu

* sort import files

* update ConsensusVersion

* update pool migration

* change v280 to v4

* add v4_test package

* migrate oracle certik prefix to shentu (#740)

* migrate oracle certik prefix to shentu

* update ConsensusVersion

* update operator migration

* add oracle withdraw migration

* sort imports

* change v280 to v3

* add v3

* migrate cert stored prefix to shentu (#739)

* migrate cert stored prefix to shentu

* sort import files

* update ConsensusVersion

* add cert library migration

* change v280 to v2

* migrate certificate.content

* [prefix-trans]migrate store for staking, gov and feegrant (#747)

* initially add staking store migration

* finish store migration for staking

* add store migration for feegrant and gov

* add unit test

* fix feegrant unit test

* fix lint

* using cosmos sdk 0.45.11-3

* add negative tests

* change impl for feegrant

* simplify code

* Store migration for slashing, auth and authz (#746)

* Store migration for slashing, auth and authz

---------

Co-authored-by: zheng-bin <wenwubinzheng@gmail.com>

* skip empty certificate's proposer (#749)

add v3

* change migration certificate MustMarshalLengthPrefixed function  to M… (#750)

* change migration certificate MustMarshalLengthPrefixed function  to MustMarshal function

* change migration certificate MustMarshalLengthPrefixed function  to MustMarshal function

* Shentu prefix revoke certificate (#754)

* fix revoke-certificate, platform cmd

* fix revoke-certificate, platform cmd

* fix revoke-certificate, platform cmd

* Replace certik word (#752)

* replace shentu

* change to shentu word

* change to shentu word

* replace to shentu

* add address prefix conversion for specific gov proposal content (#758)

* add address conversion for specific proposal contens

* add more negative test

---------

Co-authored-by: haozhan9 <zhanghao_tt@sina.com>
Co-authored-by: zheng-bin <wenwubinzheng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants