Store migration for slashing, auth and authz #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyargos
requested review from
kevin-yuhh and
haozhan9
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## prefix-trans-stkazf #746 +/- ##
=======================================================
- Coverage 47.40% 46.72% -0.68%
=======================================================
Files 130 126 -4
Lines 12563 12181 -382
=======================================================
- Hits 5955 5692 -263
+ Misses 6041 5955 -86
+ Partials 567 534 -33
|
skyargos
changed the title
kevin-yuhh
reviewed
Aug 4, 2023
app/upgrade_handler.go
Outdated
| authorization := grant.Authorization | ||
| value := authorization.GetValue() | ||
|
|
||
| switch authorization.GetTypeUrl() { |
There was a problem hiding this comment.
Is it better to use type comparison?
haozhan9
reviewed
Aug 6, 2023
| if err := ak.SaveGrant(ctx, granteeAddr, granterAddr, stakeAuthorization, grant.Expiration); err != nil { | ||
| return true | ||
| } | ||
| default: |
There was a problem hiding this comment.
just for your info:
it seems there is another Authorization, which is bank.types.SendAuthorization. But it looks like we don't have it on mainnet state.
There was a problem hiding this comment.
Yes, the current data on the chain does not have this status.
haozhan9
approved these changes
Aug 7, 2023
kevin-yuhh
approved these changes
Aug 7, 2023
This was
linked to
issues
Aug 7, 2023
haozhan9
added a commit
that referenced
this pull request
Aug 7, 2023
* initially add staking store migration * finish store migration for staking * add store migration for feegrant and gov * add unit test * fix feegrant unit test * fix lint * using cosmos sdk 0.45.11-3 * add negative tests * change impl for feegrant * simplify code * Store migration for slashing, auth and authz (#746) * Store migration for slashing, auth and authz --------- Co-authored-by: zheng-bin <wenwubinzheng@gmail.com>
kevin-yuhh
added a commit
that referenced
this pull request
Aug 24, 2023
* change address prefix to shentu * Migrate shield (#738) * migrate shield certik prefix to shentu * migrate shield certik prefix to shentu * migrate shield certik prefix to shentu * migrate shield stored prefix to shentu * sort import files * update ConsensusVersion * update pool migration * change v280 to v4 * add v4_test package * migrate oracle certik prefix to shentu (#740) * migrate oracle certik prefix to shentu * update ConsensusVersion * update operator migration * add oracle withdraw migration * sort imports * change v280 to v3 * add v3 * migrate cert stored prefix to shentu (#739) * migrate cert stored prefix to shentu * sort import files * update ConsensusVersion * add cert library migration * change v280 to v2 * migrate certificate.content * [prefix-trans]migrate store for staking, gov and feegrant (#747) * initially add staking store migration * finish store migration for staking * add store migration for feegrant and gov * add unit test * fix feegrant unit test * fix lint * using cosmos sdk 0.45.11-3 * add negative tests * change impl for feegrant * simplify code * Store migration for slashing, auth and authz (#746) * Store migration for slashing, auth and authz --------- Co-authored-by: zheng-bin <wenwubinzheng@gmail.com> * skip empty certificate's proposer (#749) add v3 * change migration certificate MustMarshalLengthPrefixed function to M… (#750) * change migration certificate MustMarshalLengthPrefixed function to MustMarshal function * change migration certificate MustMarshalLengthPrefixed function to MustMarshal function * Shentu prefix revoke certificate (#754) * fix revoke-certificate, platform cmd * fix revoke-certificate, platform cmd * fix revoke-certificate, platform cmd * Replace certik word (#752) * replace shentu * change to shentu word * change to shentu word * replace to shentu * add address prefix conversion for specific gov proposal content (#758) * add address conversion for specific proposal contens * add more negative test --------- Co-authored-by: haozhan9 <zhanghao_tt@sina.com> Co-authored-by: zheng-bin <wenwubinzheng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Related: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)