-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement in-place store migration #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To my understanding consensusversion for all modules should be a hardcoded value that gets updated for each in-store migrations. Might wanna fix that 🤔 |
might as well remove gov's txhash fields from vote and deposit here as well? wdyt |
* module level migration WIP * add auth migration again after first migration
byeongminP
approved these changes
Nov 23, 2021
priyanshiiit
pushed a commit
to priyanshiiit/shentu
that referenced
this pull request
Dec 1, 2021
* implement in-place store migration * fix consensus versions and add a test * update unit test * lint * remove tx hash from gov votes and add migration * remove tx hash from gov type Deposit * unit test fix * update upgrade name * separate migration logic from app.go * reorder upgrade handler and register legacy types for migration * APP: Fix Auth module MVA in-place migration (shentufoundation#344) * module level migration WIP * add auth migration again after first migration * changelog * Update CHANGELOG.md Co-authored-by: yoongbok-lee <52583590+yoongbok-lee@users.noreply.github.com>
byeongminP
added a commit
that referenced
this pull request
Dec 1, 2021
* feat: bump cosmos and ibc proto files * feat: bump dependencies in go.mod and add ibc * chore: run proto-gen * feat: rename codec interfaces and methods * feat: update API breaking name and parameter changes * fix: make vote options weighted * chore: remove legacy migration code * feat: add authz and feegrant modules * feat: remove unsafe bank module apis in module tests feat: add authz and feegrant modules to simapp fix: replace InitializeandSeal with Seal in app * feat: remove bech32 pubkey support * feat: get rid of unsafe bank module api in cvm and cert fix: update upgrade handler template * fix composite literal warning in simapp * fix: correctly mint and burn tokens in cvm * fix: uncomment check for expired entries in shield purchase * fix: remove capability seal and upgrade handler contents * fix: use NewNonSplitVoteOption for single option votes * fix: use sdk simapp test helpers * chore: separate ibc imports from sdk imports * SDK: 0.44.3 upgrade from 0.44.0 & sim test fix (#331) * fix some bugs & structs. upgrade to sdk 0.44.3 * remove authz and feegrant modules * revert banktypes to sdkbanktypes * rename Codec to Marshaler, and fix simulations * fix gov tally logic * add evidence to exportgenesis * refactor voteoptions handling * CI: fix lint failure (#335) * add dependencies requirement to lint * update golang version * add timeout config to lint * Update Changelog to Reflect SDK v0.44.3 Bump (#336) * chore: clean up and add entries to changelog * chore: update changelog to reflect recent changes Co-authored-by: Michael Park <michael.park@certik.org> * Implement in-place store migration (#334) * implement in-place store migration * fix consensus versions and add a test * update unit test * lint * remove tx hash from gov votes and add migration * remove tx hash from gov type Deposit * unit test fix * update upgrade name * separate migration logic from app.go * reorder upgrade handler and register legacy types for migration * APP: Fix Auth module MVA in-place migration (#344) * module level migration WIP * add auth migration again after first migration * changelog * Update CHANGELOG.md Co-authored-by: yoongbok-lee <52583590+yoongbok-lee@users.noreply.github.com> * run lint * Oracle: Add sender checks when removing an operator (#345) * upgrade go-ibc to 2.0.0 (#348) * fix upgrade order (#349) Co-authored-by: Michael Park <michael.park@certik.org> Co-authored-by: Subal Pant <email@example.com> Co-authored-by: yoongbok-lee <52583590+yoongbok-lee@users.noreply.github.com> Co-authored-by: Hyoung-yoon Kim <hy.kim@certik.org> Co-authored-by: yoongbok lee <yoongbok.lee@certik.org>
yoongbok-lee
added a commit
that referenced
this pull request
Feb 1, 2022
* feat: bump cosmos and ibc proto files * feat: bump dependencies in go.mod and add ibc * chore: run proto-gen * feat: rename codec interfaces and methods * feat: update API breaking name and parameter changes * fix: make vote options weighted * chore: remove legacy migration code * feat: add authz and feegrant modules * feat: remove unsafe bank module apis in module tests feat: add authz and feegrant modules to simapp fix: replace InitializeandSeal with Seal in app * feat: remove bech32 pubkey support * feat: get rid of unsafe bank module api in cvm and cert fix: update upgrade handler template * fix composite literal warning in simapp * fix: correctly mint and burn tokens in cvm * fix: uncomment check for expired entries in shield purchase * fix: remove capability seal and upgrade handler contents * fix: use NewNonSplitVoteOption for single option votes * fix: use sdk simapp test helpers * chore: separate ibc imports from sdk imports * SDK: 0.44.3 upgrade from 0.44.0 & sim test fix (#331) * fix some bugs & structs. upgrade to sdk 0.44.3 * remove authz and feegrant modules * revert banktypes to sdkbanktypes * rename Codec to Marshaler, and fix simulations * fix gov tally logic * add evidence to exportgenesis * refactor voteoptions handling * CI: fix lint failure (#335) * add dependencies requirement to lint * update golang version * add timeout config to lint * Update Changelog to Reflect SDK v0.44.3 Bump (#336) * chore: clean up and add entries to changelog * chore: update changelog to reflect recent changes Co-authored-by: Michael Park <michael.park@certik.org> * fix: add param validation and testing for genesis * test: revise msg test for consistency * Implement in-place store migration (#334) * implement in-place store migration * fix consensus versions and add a test * update unit test * lint * remove tx hash from gov votes and add migration * remove tx hash from gov type Deposit * unit test fix * update upgrade name * separate migration logic from app.go * reorder upgrade handler and register legacy types for migration * APP: Fix Auth module MVA in-place migration (#344) * module level migration WIP * add auth migration again after first migration * changelog * Update CHANGELOG.md Co-authored-by: yoongbok-lee <52583590+yoongbok-lee@users.noreply.github.com> * run lint * Oracle: Add sender checks when removing an operator (#345) * test: add grpc test * chore: make lint * chore: move operator testing to separate file Co-authored-by: Michael Park <michael.park@certik.org> Co-authored-by: Subal Pant <email@example.com> Co-authored-by: yoongbok-lee <52583590+yoongbok-lee@users.noreply.github.com> Co-authored-by: Hyoung-yoon Kim <hy.kim@certik.org> Co-authored-by: yoongbok lee <yoongbok.lee@certik.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.