Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle: Unit Testing for SDK v0.44.3 Upgrade #347

Merged
merged 38 commits into from
Feb 1, 2022
Merged

Conversation

byeongminP
Copy link
Contributor

Closes: #XXX
Related: #341


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

Michael Park and others added 30 commits September 13, 2021 15:16
feat: add authz and feegrant modules to simapp
fix: replace InitializeandSeal with Seal in app
fix: update upgrade handler template
* fix some bugs & structs. upgrade to sdk 0.44.3

* remove authz and feegrant modules

* revert banktypes to sdkbanktypes

* rename Codec to Marshaler, and fix simulations

* fix gov tally logic

* add evidence to exportgenesis

* refactor voteoptions handling
* add dependencies requirement to lint

* update golang version

* add timeout config to lint
* chore: clean up and add entries to changelog

* chore: update changelog to reflect recent changes

Co-authored-by: Michael Park <michael.park@certik.org>
* implement in-place store migration

* fix consensus versions and add a test

* update unit test

* lint

* remove tx hash from gov votes and add migration

* remove tx hash from gov type Deposit

* unit test fix

* update upgrade name

* separate migration logic from app.go

* reorder upgrade handler and register legacy types for migration

* APP: Fix Auth module MVA in-place migration (#344)

* module level migration WIP

* add auth migration again after first migration

* changelog

* Update CHANGELOG.md

Co-authored-by: yoongbok-lee <52583590+yoongbok-lee@users.noreply.github.com>
Base automatically changed from bm/sdkv0.44.0 to master December 1, 2021 23:48
@uwezukwechibuzor uwezukwechibuzor marked this pull request as ready for review December 29, 2021 21:17
@yoongbok-lee
Copy link
Collaborator

I think this is still somewhat WIP? maybe somebody can take over and finish it.

@yoongbok-lee
Copy link
Collaborator

merging this in and probably fixing the unfinished stuff later.

@yoongbok-lee yoongbok-lee merged commit dff7919 into master Feb 1, 2022
@yoongbok-lee yoongbok-lee deleted the bm/oracle_test branch February 1, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants