SDK: Bump Cosmos SDK to v0.44.3 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add authz and feegrant modules to simapp fix: replace InitializeandSeal with Seal in app
fix: update upgrade handler template
soundreaper
force-pushed
the
bm/sdkv0.44.0
branch
from
732babe
to
f7f8cbc
Compare
yoongbok-lee
requested changes
Nov 9, 2021
uwezukwechibuzor
approved these changes
Nov 9, 2021
|
I think mint and burn for CVM is fine for now. Also why did we change config.Marshaler to config.Codec? |
|
Cosmos renamed codec interfaces and methods from |
* fix some bugs & structs. upgrade to sdk 0.44.3 * remove authz and feegrant modules * revert banktypes to sdkbanktypes * rename Codec to Marshaler, and fix simulations * fix gov tally logic * add evidence to exportgenesis * refactor voteoptions handling
uwezukwechibuzor
approved these changes
Nov 10, 2021
byeongminP
changed the title
* add dependencies requirement to lint * update golang version * add timeout config to lint
yoongbok-lee
approved these changes
Nov 11, 2021
|
Let's merge it in after writing a good changelog |
11 tasks
hacheigriega
approved these changes
Nov 15, 2021
| @@ -162,7 +162,8 @@ func (k msgServer) Vote(goCtx context.Context, msg *govtypes.MsgVote) (*govtypes | |||
| if accErr != nil { | |||
| return nil, accErr | |||
| } | |||
| err := k.Keeper.AddVote(ctx, msg.ProposalId, accAddr, msg.Option) | |||
| options := govtypes.NewNonSplitVoteOption(msg.Option) | |||
There was a problem hiding this comment.
No need to create a variable here
* chore: clean up and add entries to changelog * chore: update changelog to reflect recent changes Co-authored-by: Michael Park <michael.park@certik.org>
* implement in-place store migration * fix consensus versions and add a test * update unit test * lint * remove tx hash from gov votes and add migration * remove tx hash from gov type Deposit * unit test fix * update upgrade name * separate migration logic from app.go * reorder upgrade handler and register legacy types for migration * APP: Fix Auth module MVA in-place migration (#344) * module level migration WIP * add auth migration again after first migration * changelog * Update CHANGELOG.md Co-authored-by: yoongbok-lee <52583590+yoongbok-lee@users.noreply.github.com>
yoongbok-lee
force-pushed
the
bm/sdkv0.44.0
branch
from
e8f5f1c
to
7a237ab
Compare
|
Let's merge this in and prepare for a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Related: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)