Streams rewrite #906
Merged
Streams rewrite #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
force-pushed
the
streams
branch
5 times, most recently
from
abfd3ca to
a02b2b0
Compare
| * [`.write(data, [callback])`](#module_serialport--SerialPort+write) | ||
| * [`.pause()`](#module_serialport--SerialPort+pause) | ||
| * [`.resume()`](#module_serialport--SerialPort+resume) | ||
| * [`._write(data, [callback])`](#module_serialport--SerialPort+_write) |
There was a problem hiding this comment.
Given this is now a stream, _write should probably not be documented.
reconbot
force-pushed
the
streams
branch
4 times, most recently
from
72f6d57 to
f272fd0
Compare
reconbot
force-pushed
the
streams
branch
8 times, most recently
from
4690c57 to
6bbf611
Compare
reconbot
force-pushed
the
streams
branch
2 times, most recently
from
c663090 to
df01e89
Compare
reconbot
force-pushed
the
streams
branch
8 times, most recently
from
195c919 to
280cfe6
Compare
|
We've now got unix read polling. I've only tested osx but linux should work as well. We should in theory have similar performance to the 4x releases with a little more read and write buffering. This should also solve the memory leak from #923 as we have a rewritten poller but that also needs verification. |
reconbot
force-pushed
the
streams
branch
6 times, most recently
from
8325e0a to
bbd7186
Compare
Current coverage is 85.36% (diff: 81.62%)@@ master #906 diff @@
==========================================
Files 7 13 +6
Lines 394 656 +262
Methods 58 111 +53
Messages 0 0
Branches 88 156 +68
==========================================
+ Hits 192 560 +368
+ Misses 202 96 -106
Partials 0 0
|
reconbot
force-pushed
the
streams
branch
2 times, most recently
from
5930179 to
9cbd630
Compare
|
We don't have windows support yet, nor do we have the poller memory leak solved but I think I want to merge to master so we can work on these issues independently. |
reconbot
force-pushed
the
streams
branch
9 times, most recently
from
fd445d3 to
1c1387f
Compare
This is a major change. To reading, the poller and the bindings layer, there isn’t a great way to do this piecemeal. The goal here is to make bindings a plugin layer, our c++ bindings isolated and tested, and make Serialport a streams object. - Move all bindings into platform specific modules DarwinBinding LinuxBinding, and WindowsBinding - Separate out the bindings from the SerialPort class so it can be required by itself. - Provide mock bindings as a tested first class bindings layer - Mixin stream methods with `pushBindingWrap`, inspired from fs.readStream - All integration tests now require an Arduino - Ditch sandboxed modules as we don't need to be that heavy handed to test anymore TODO - windows binding - performance test - memory leak test - 🎉
This was referenced Nov 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major change. To reading, the poller and the bindings layer, there isn’t a great way to do this piecemeal. The goal here is to make bindings a plugin layer, our c++ bindings isolated and tested, and make Serialport a streams object.
pushBindingWrap, inspired from fs.readStreamTODO