Finish WindowsBinding reading

[reconbot]

Follow up from #906 which removed the read loop from the windows binding but didn't yet add in a new read() function that worked.

[munyirik]

This looks like it will require a Read method to be added to serialport.cpp. Is that correct?

[reconbot]

yep

[munyirik]

Should reads be queueable?

[reconbot]

They don't need to be, we're guaranteeing not to call it again until the
callback returns, as long as the binding guarantees to always return at
least one byte of data. (We use epoll on Unix, I forget the method on
Windows)

On Fri, Nov 11, 2016, 6:31 PM Mũnyĩrĩ Kamau notifications@github.com
wrote:

Should reads be queueable?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#994 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABlbuQ8PaTljip6bWyi8XiF0MEaWQYqks5q9Pq4gaJpZM4KqHrt
.

[munyirik]

How were you thinking of handling data events? (since AfterOpenSuccess/EIO_WatchPort have been removed).

[reconbot]

When someone wants data they ask for it, if no data is available read won't return until there is data. The stream mechanics take care of continuously asking for data in streaming mode. No events needed.

[reconbot]

This is already done thanks to @munyirik =)