Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Streams Rewrite Performance and Memory consumption #995

Closed
reconbot opened this issue Nov 5, 2016 · 3 comments
Closed

Test Streams Rewrite Performance and Memory consumption #995

reconbot opened this issue Nov 5, 2016 · 3 comments

Comments

@reconbot
Copy link
Member

reconbot commented Nov 5, 2016

Follow up from #906 to ensure we don't have any memory leaks and are near performant as 4x.

@jalafel
Copy link
Contributor

jalafel commented Jan 25, 2017

@reconbot I would love to give this issue a go! Though, I am not sure where to get started ... is there a similar test found in v4x I can base this from? :)

@reconbot
Copy link
Member Author

There's not a lot. We have some "manual" tests that might be worth looking at. I've used valgrind to find c++ memory leaks before, and the devtools to look for growing heaps.

https://github.com/EmergingTechnologyAdvisors/node-serialport/tree/master/test/manual-testing

I have no well defined view of what this should look like, or examples from other projects. I wonder what's out there. =)

@reconbot
Copy link
Member Author

reconbot commented Jul 6, 2017

The #1212 improves this so much I don't even care to keep this issue open anymore.

@reconbot reconbot closed this as completed Jul 6, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants