fix: do not exit with exec permission error in ninja check #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also `cmake` check. As discussed in: https://github.com/orgs/scikit-build/discussions/1057 There may be times when we attempt to execute `ninja --version` from the ninja package in /tmp/, which may be mounted `noexec`. This result in a PermissionError. Carry on so we can inspect other ninja executables available.
henryiii
approved these changes
Feb 2, 2024
|
Released 0.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
cmakecheck.As discussed in:
https://github.com/orgs/scikit-build/discussions/1057
There may be times when we attempt to execute
ninja --versionfrom the ninja package in /tmp/, which may be mountednoexec. This result in a PermissionError.Carry on so we can inspect other ninja executables available.