Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not exit with exec permission error in ninja check #626

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix: do not exit with exec permission error in ninja check #626

merged 1 commit into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. fix: do not exit with exec permission error in ninja check 

    Also `cmake` check.

As discussed in:

  https://github.com/orgs/scikit-build/discussions/1057

There may be times when we attempt to execute `ninja --version` from the
ninja package in /tmp/, which may be mounted `noexec`. This
result in a PermissionError.

Carry on so we can inspect other ninja executables available.
    @thewtex
    thewtex committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b21574d View commit details
    Browse the repository at this point in the history