Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all artefacts from dotty to scala3 #9917

Merged
merged 13 commits into from
Oct 15, 2020

Conversation

anatoliykmetyuk
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk commented Sep 30, 2020

Checklist:

  • Investigate breakage of the sbt-dotty/scripted tests.
  • Rename executables: dotty -> scala.
  • Revert the full CI tests commit.
  • Modify CB projects: update the name of the SBT plugin. Note that if a CB project hard-codes the SBT plugin in project/plugins.sbt, the --addPluginSbtFile=/Users/kmetiuk/Projects/scala3/dotty/community-build/sbt-scala3-sbt will not take effect.

Blocked upon

  • Merge Add support for Scala 3 com-lihaoyi/mill#968 which adds support of the new naming schema to Mill.
  • Update the community build to use the new Mill with the added naming support.
  • Make the publishing procedure use the new credentials for org.scala-lang.
  • Successfully publish a nightly release following the standard procedure.

@anatoliykmetyuk anatoliykmetyuk self-assigned this Sep 30, 2020
project/Build.scala Outdated Show resolved Hide resolved
@anatoliykmetyuk anatoliykmetyuk force-pushed the scala3m1 branch 3 times, most recently from 506e65e to 3ea0e85 Compare September 30, 2020 13:20
@anatoliykmetyuk anatoliykmetyuk marked this pull request as ready for review September 30, 2020 13:53
project/Build.scala Outdated Show resolved Hide resolved
@smarter
Copy link
Member

smarter commented Oct 6, 2020

Once we have a nightly with this PR in, we should update our reference compiler to this nightly and use that for a few days to make sure everything works OK before doing the M1 release.

@unkarjedy
Copy link
Contributor

Once we have a nightly with this PR in, we should update our reference compiler to this nightly and use that for a few days to make sure everything works OK before doing the M1 release.

Is there a chance that new artefacts will be published in some non-release public repo before the release?

@anatoliykmetyuk
Copy link
Contributor Author

Nightlies are available in the public repo. See e.g. https://repo1.maven.org/maven2/ch/epfl/lamp/dotty-compiler_0.28/

project/Build.scala Outdated Show resolved Hide resolved
@anatoliykmetyuk anatoliykmetyuk force-pushed the scala3m1 branch 2 times, most recently from 0f87299 to bf97594 Compare October 9, 2020 14:27
smarter
smarter previously requested changes Oct 9, 2020
build.sbt Outdated Show resolved Hide resolved
packArchiveName changed to scala3-

Correctly name SBT plugin

Update Windows CI to use the new naming scheme
Read latest nightly metadata from the scala3-compiler artefact

Co-authored-by: Guillaume Martres <smarter@ubuntu.com>

Properly set binary version for Scala 3

Fetch Dotty nightlies correctly
Fix scala#9024: Don't publish empty compat jars

Delete dummy projects
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks for all your work! 🎆

project/Build.scala Outdated Show resolved Hide resolved
@smarter
Copy link
Member

smarter commented Oct 15, 2020

(Once this is merged, a new release of sbt-dotty will need to be published to let people test the nightly builds)

Co-authored-by: Guillaume Martres <smarter@ubuntu.com>
@anatoliykmetyuk anatoliykmetyuk merged commit c0b527d into scala:master Oct 15, 2020
@anatoliykmetyuk anatoliykmetyuk deleted the scala3m1 branch October 15, 2020 17:25
@smarter
Copy link
Member

smarter commented Oct 16, 2020

The publishing of sbt-dotty-v0.4.3 failed: https://github.com/lampepfl/dotty/actions/runs/310382379, I've deleted and repushed the tag after fixing shapeless (#10021): https://github.com/lampepfl/dotty/actions/runs/310570439

griggt added a commit to griggt/dotty that referenced this pull request Oct 22, 2020
Update references from `dotc` and `dotr` to `scalac` and `scala`,
respectively, as they were renamed by scala#9917.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants