Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated docs and links to them (#1) #10015

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Remove deprecated docs and links to them (#1) #10015

merged 1 commit into from
Oct 16, 2020

Conversation

ysthakur
Copy link
Contributor

  • Use new links

Right now, there are multiple features with links that just say "The contents of this page have moved." It'd be more convenient if the links directly went to the updated pages.

  • Delete implicit-function-types-spec.md

  • Delete implicit-function-types.md

  • Delete delegates.md

  • Delete given-clauses.md

  • Update features-classification.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Use new links 

Right now, there are multiple features with links that just say "The contents of this page have moved." It'd be more convenient if the links directly went to the updated pages.

* Delete implicit-function-types-spec.md

* Delete implicit-function-types.md

* Delete delegates.md

* Delete given-clauses.md

* Update features-classification.md
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@ysthakur ysthakur marked this pull request as ready for review October 16, 2020 00:07
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @ysthakur 🎉

@liufengyun liufengyun merged commit 492d221 into scala:master Oct 16, 2020
@ysthakur
Copy link
Contributor Author

It seems the features part of the front page has disappeared. I'm not sure why, because the links I changed are working. If it's because of this PR, I apologize. @liufengyun Do you want to revert and see if this commit was the problem?

@griggt
Copy link
Contributor

griggt commented Oct 16, 2020

@ysthakur The features section was removed yesterday by d982469 in #9917

@liufengyun
Copy link
Contributor

It seems the features part of the front page has disappeared. I'm not sure why, because the links I changed are working. If it's because of this PR, I apologize. @liufengyun Do you want to revert and see if this commit was the problem?

No worry, @ysthakur, thanks for double-checking the live site. Yes, as @griggt pointed out, the change to the home page is intentional.

@ysthakur
Copy link
Contributor Author

Ah, that's a relief.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants