-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Scala 3 #968
Conversation
Travis fails with:
Any idea what causes it? |
We need to rerun CI. I usually |
Unfortunately, reruning the Travis-CI jobs won't resolve the issue. Only chance is to rebase the branch on latest master. P.S. I'm working on a GitHub Actions setup to overcome these limitations. |
1f765ee
to
4240b97
Compare
Seeing this test failure in the CI logs:
|
bac2330
to
037436d
Compare
037436d
to
3ad27cf
Compare
4d1a7f2
to
635773e
Compare
I believe my branch is already on top of the latest master. I'm trying the trick with |
Tests are running, some are already green. No need to rebase again (for now). I restarted the second, which fails alsmost any second time but outside of our control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tests are green. Merging now...
Thank you!
Thanks, @lefou! Will it be available somewhere as a nightly so that we can use it? |
This PR is a blocker for scala/scala3#9917. We have a bunch of libraries compiled with Mill in the Dotty community build, and we'd rather not disable them during the artefacts naming change.
@lihaoyi what's the policy on the Mill nightly builds? How soon will we be able to use this change in a nightly build once this is merged?