Refactor and clean up IndentationRule
#1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * See #1448.
Codecov Report
@@ Coverage Diff @@
## master #1470 +/- ##
============================================
- Coverage 83.33% 83.30% -0.03%
+ Complexity 2562 2561 -1
============================================
Files 107 109 +2
Lines 7614 7655 +41
Branches 2100 2106 +6
============================================
+ Hits 6345 6377 +32
- Misses 384 391 +7
- Partials 885 887 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Jul 21, 2022
diktat-rules/src/test/kotlin/org/cqfn/diktat/util/DiktatRuleSetProvider4Test.kt
Show resolved
Hide resolved
petertrr
approved these changes
Jul 21, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/indentation/Checkers.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Show resolved
Hide resolved
### What's done: * Now, we examine only the 1st 150 lines of each file when looking for the superclass constructor call.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-rules/src/test/kotlin/org/cqfn/diktat/util/DiktatRuleSetProvider4Test.kt
Fixed
Show fixed
Hide fixed
### What's done: * Test code cleaned up.
diktat-rules/src/test/kotlin/org/cqfn/diktat/util/DiktatRuleSetProvider4Test.kt
Fixed
Show fixed
Hide fixed
### What's done: * Test code reformatted.
### What's done: * Now, `CustomIndentationChecker` implements `IndentationConfigAware`.
0x6675636b796f75676974687562
deleted the
bugfix/andrey.shcheglov/indentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
WRONG_INDENTATION: a newline after(within an expression should result in the extended indent for the remainder of the expression #1448.