-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify the code by implementing
IndentationConfigAware
### What's done: * Now, `CustomIndentationChecker` implements `IndentationConfigAware`.
- Loading branch information
1 parent
b59fe91
commit 73365d4
Showing
6 changed files
with
248 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
...les/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/spaces/IndentationConfigAwareTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| package org.cqfn.diktat.ruleset.chapter3.spaces | ||
|
|
||
| import org.cqfn.diktat.ruleset.chapter3.spaces.IndentationRuleTestMixin.IndentationConfig | ||
| import org.cqfn.diktat.ruleset.rules.chapter3.files.IndentationAmount.EXTENDED | ||
| import org.cqfn.diktat.ruleset.rules.chapter3.files.IndentationAmount.NONE | ||
| import org.cqfn.diktat.ruleset.rules.chapter3.files.IndentationAmount.SINGLE | ||
| import org.cqfn.diktat.ruleset.rules.chapter3.files.IndentationConfigAware.Factory.withIndentationConfig | ||
|
|
||
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.junit.jupiter.api.MethodOrderer.DisplayName | ||
| import org.junit.jupiter.api.TestMethodOrder | ||
| import org.junit.jupiter.params.ParameterizedTest | ||
| import org.junit.jupiter.params.provider.ValueSource | ||
|
|
||
| @TestMethodOrder(DisplayName::class) | ||
| class IndentationConfigAwareTest { | ||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun `Int + IndentationAmount`(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(42 + NONE).isEqualTo(42) | ||
| assertThat(42 + SINGLE).isEqualTo(42 + indentationSize) | ||
| assertThat(42 + EXTENDED).isEqualTo(42 + 2 * indentationSize) | ||
| } | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun `Int - IndentationAmount`(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(42 - NONE).isEqualTo(42) | ||
| assertThat(42 - SINGLE).isEqualTo(42 - indentationSize) | ||
| assertThat(42 - EXTENDED).isEqualTo(42 - 2 * indentationSize) | ||
| } | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun `IndentationAmount + Int`(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(NONE + 42).isEqualTo(42 + NONE) | ||
| assertThat(SINGLE + 42).isEqualTo(42 + SINGLE) | ||
| assertThat(EXTENDED + 42).isEqualTo(42 + EXTENDED) | ||
|
|
||
| assertThat(42 + (SINGLE + 2)).isEqualTo((42 + SINGLE) + 2) | ||
| } | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun `IndentationAmount - Int`(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(NONE - 42).isEqualTo(-(42 - NONE)) | ||
| assertThat(SINGLE - 42).isEqualTo(-(42 - SINGLE)) | ||
| assertThat(EXTENDED - 42).isEqualTo(-(42 - EXTENDED)) | ||
|
|
||
| assertThat(42 - (SINGLE - 2)).isEqualTo(42 - SINGLE + 2) | ||
| } | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun `IndentationAmount + IndentationAmount`(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(NONE + SINGLE).isEqualTo(0 + SINGLE) | ||
| assertThat(SINGLE + SINGLE).isEqualTo(0 + EXTENDED) | ||
|
|
||
| assertThat(42 + SINGLE + SINGLE).isEqualTo(42 + EXTENDED) | ||
| assertThat(42 + (SINGLE + SINGLE)).isEqualTo(42 + EXTENDED) | ||
| } | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun `IndentationAmount - IndentationAmount`(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(NONE - SINGLE).isEqualTo(0 - SINGLE) | ||
| assertThat(SINGLE - SINGLE).isEqualTo(0) | ||
| assertThat(EXTENDED - SINGLE).isEqualTo(0 + SINGLE) | ||
| assertThat(NONE - EXTENDED).isEqualTo(0 - EXTENDED) | ||
|
|
||
| assertThat(42 + (SINGLE - SINGLE)).isEqualTo(42 + SINGLE - SINGLE) | ||
| } | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun unaryPlus(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(+NONE).isEqualTo(0) | ||
| assertThat(+SINGLE).isEqualTo(indentationSize) | ||
| assertThat(+EXTENDED).isEqualTo(2 * indentationSize) | ||
|
|
||
| assertThat(EXTENDED - SINGLE).isEqualTo(+SINGLE) | ||
| } | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "indentationSize = {0}") | ||
| @ValueSource(ints = [2, 4, 8]) | ||
| fun unaryMinus(indentationSize: Int) { | ||
| val config = IndentationConfig("indentationSize" to indentationSize) | ||
|
|
||
| withIndentationConfig(config) { | ||
| assertThat(-NONE).isEqualTo(0) | ||
| assertThat(-SINGLE).isEqualTo(-indentationSize) | ||
| assertThat(-EXTENDED).isEqualTo(-2 * indentationSize) | ||
|
|
||
| assertThat(NONE - SINGLE).isEqualTo(-SINGLE) | ||
| assertThat(NONE - EXTENDED).isEqualTo(-EXTENDED) | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.