Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRONG_INDENTATION: a newline after ( within an expression should result in the extended indent for the remainder of the expression #1448

Closed
0x6675636b796f75676974687562 opened this issue Jul 13, 2022 · 0 comments · Fixed by #1457, #1470, #1473, #1474 or #1475
Closed

WRONG_INDENTATION: a newline after ( within an expression should result in the extended indent for the remainder of the expression #1448

0x6675636b796f75676974687562 opened this issue Jul 13, 2022 · 0 comments · Fixed by #1457, #1470, #1473, #1474 or #1475
Assignees
@0x6675636b796f75676974687562
Labels
bug Something isn't working
Milestone
1.2.2

Comments

@0x6675636b796f75676974687562
Copy link
Member

0x6675636b796f75676974687562 commented Jul 13, 2022 •
edited
Loading

Consider this fragment (extendedIndentForExpressionBodies is off, extendedIndentAfterOperators is on). Note the expressions are wrapped immediately after the opening parenthesis:

val v1 = (
        true)

val v2 = (
        1 + 2)

This is exactly how IDEA with Kotlin style settings applied formats the fragment:

IDEA

For IDEA, the continuation indent is non-configurable and is always on.

diKTat

Expected behaviour

For diKTat, the indent within an expression should depend on the value of extendedIndentAfterOperators.

Actual behaviour

Still, diKTat expects a single indent regardless of extendedIndentAfterOperators. In fact, none of the extendedIndent* flags can change the actual behaviour in this context.

Notes

Environment information

  • diktat version: 1.2.2-SNAPSHOT at a17825a
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added the bug Something isn't working label Jul 13, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.2 milestone Jul 13, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 linked a pull request Jul 21, 2022 that will close this issue
Remove dead code #1457
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 21, 2022
@0x6675636b796f75676974687562
Refactor and clean up IndentationRule
378cf81 
### What's done:

 * See #1448.
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 22, 2022
@0x6675636b796f75676974687562
Refactor and clean up IndentationRule (#1470)
cb017a9 
### What's done:

 * See #1448.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 linked a pull request Jul 22, 2022 that will close this issue
Refactor and clean up IndentationRule #1470
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 25, 2022
@0x6675636b796f75676974687562
Rewrite getParenthesisIndentationChange() to return `IndentationAmo…
3c7f970 
…unt`

### What's done:

 * `isParenthesisAffectingIndent()` renamed to `getParenthesisIndentationChange()`.
 * The return type changed from `Boolean` to `IndentationAmount`.
 * The value returned by `getParenthesisIndentationChange()` is now stored on
   the "indentation stack" along with the corresponding element types.
 * See #1448.
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 25, 2022
@0x6675636b796f75676974687562
Rewrite getParenthesisIndentationChange() to return `IndentationAmo…
632ac74 
…unt` (#1473)

### What's done:

 * `isParenthesisAffectingIndent()` renamed to `getParenthesisIndentationChange()`.
 * The return type changed from `Boolean` to `IndentationAmount`.
 * The value returned by `getParenthesisIndentationChange()` is now stored on
   the "indentation stack" along with the corresponding element types.
 * This is merely a refactoring, so no user-visible behaviour has been changed.
 * See #1448.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 linked a pull request Jul 25, 2022 that will close this issue
Rewrite getParenthesisIndentationChange() to return IndentationAmount #1473
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 25, 2022
@0x6675636b796f75676974687562
Move ASTNode extensions from the companion object to IndentationRule
fade426 
### What's done:

 * This is merely a refactoring, so no user-visible behaviour has been changed.
 * See #1448.
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 25, 2022
@0x6675636b796f75676974687562
Move ASTNode extensions from the companion object to `IndentationRu…
7f068a8 
…le` (#1474)

### What's done:

 * This is merely a refactoring, so no user-visible behaviour has been changed.
 * See #1448.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 linked a pull request Jul 25, 2022 that will close this issue
Move ASTNode extensions from the companion object to IndentationRule #1474
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 25, 2022
@0x6675636b796f75676974687562
Add support for an extended indent after an opening ( in expressions
0cd4aa1 
### What's done:

 * The value of the indent is controlled with the `extendedIndentAfterOperators`
   flag.
 * Fixes #1448.
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Jul 25, 2022
@0x6675636b796f75676974687562
Add support for an extended indent after an opening ( in expressions (
efc40ba 
#1475)

### What's done:

 * The value of the indent is controlled with the `extendedIndentAfterOperators`
   flag.
 * Fixes #1448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x6675636b796f75676974687562 0x6675636b796f75676974687562

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.2
1 participant
@0x6675636b796f75676974687562