The mysql version check inverted #51240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is greater than or equal to 8.0.11 was testing for less than or equal to 8.0.11. This then used the password(_) function in the incorrect context.
|
This was supposed to go in against tag 2018.3.3. I'm not sure what went wrong. Selecting the tag on the pull request screen sent me into a code comparison mode. |
waynegemmell
changed the title
waynegemmell
pushed a commit
to waynegemmell/mysql-formula
that referenced
this pull request
Jan 18, 2019
I've added support for the official mysql 8.0 packages and the relevant repositories. Package names are mysql-community-server and mysql-community-client. I know the repo setting breaks convention a bit but it is compulsory so I'm not sure how else to properly include it. This change requires the salt pull request I created saltstack/salt#51240 to be able to grant users.
rares-pop
reviewed
Jan 18, 2019
salt/modules/mysql.py
Outdated
| @@ -1242,7 +1242,7 @@ def user_exists(user, | |||
| else: | |||
| qry += ' AND ' + password_column + ' = \'\'' | |||
| elif password: | |||
| if salt.utils.versions.version_cmp(server_version, '8.0.11') <= 0: | |||
| if salt.utils.versions.version_cmp(server_version, '8.0.11') >= 0: | |||
There was a problem hiding this comment.
what about salt.utils.versions.LooseVersion(server_version) >= '8.0.11'
|
@waynegemmell Looks like your local branch was against |
garethgreenaway
added
the
bugfix-bckport
|
Looking closer at the code already committed, this was fixed in #49918. |
garethgreenaway
removed
the
bugfix-bckport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql version check that was supposed to test whether the version is greater than or equal to 8.0.11 was testing for less than or equal to 8.0.11. This then used the password(_) function in the incorrect context.
Tests written?
No
Commits signed with GPG?
No