-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for official mysql 8 packages #212
Support for official mysql 8 packages #212
Conversation
I've added support for the official mysql 8.0 packages and the relevant repositories. Package names are mysql-community-server and mysql-community-client. I know the repo setting breaks convention a bit but it is compulsory so I'm not sure how else to properly include it. This change requires the salt pull request I created saltstack/salt#51240 to be able to grant users.
mysql/server.sls
Outdated
mysql_password_debconf: | ||
debconf.set: | ||
- name: mysql-server | ||
- name: {{ mysql.serverpkg }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't there an issue with mariadb-server which has the same debconf settings as mysql-server?
see: #160
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert that change, it wasn't really necessary after I realised that mysql-community-server has it's own set of debconf settings.
In #186 I added standardized mapping files but unfortunately skipped the Hi @waynegemmell any chance you could introduce a codenamemap.yaml for this PR? |
I'll have a look at the codenamemap.yaml. Not sure what that entails. I'll let you know if I can't come right. |
Sorry, can you please explain the purpose of the codenamemap.yaml file in this context? |
I understand the purpose of the codenamemap is to handle OS release specific differences. So if you need to handle an official repo from some distro this method scales best.
Here are three examples of implementations people done.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some work to fix conflicts.
I fixed the conflicts and merging. This PR is causing a backlog. |
🎉 This PR is included in version 0.55.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I've added support for the official mysql 8.0 packages and the relevant repositories.
Package names are mysql-community-server and mysql-community-client.
I know the repo setting breaks convention a bit but it is compulsory so I'm not sure how else to properly include it.
This change requires the salt pull request I created saltstack/salt#51240 to be able to grant users.