[2018.3] Fixes to MySQL module #49918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updating the mysql update to handle changes in version 8.0.11 where PASSWORD was removed. Updating unit tests.
What issues does this PR fix or reference?
#48204
Previous Behavior
Release 8.0.11 removed the PASSWORD function to generate passwords from string. Previous this was used when creating a user as well as comparing existing passwords to those provided via CLI or in a state file.
New Behavior
Check version, if 8.0.11 or greater we use avoid using PASSWORD and when comparing passwords use a new function
verify_loginto test if the username & password work.Tests written?
Yes. Existing tests updated.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.