Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packages on Windows client to be newer than latest in win_repo #11602

Closed
eliasp opened this issue Mar 27, 2014 · 6 comments · Fixed by #12711
Closed

Allow packages on Windows client to be newer than latest in win_repo #11602

eliasp opened this issue Mar 27, 2014 · 6 comments · Fixed by #12711
Assignees
Labels
Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps State-Module Windows
Milestone

Comments

@eliasp
Copy link
Contributor

eliasp commented Mar 27, 2014

When a Windows client updates its packages to a newer version than the latest version available in the win_repo, applying the state will not succeed for this client.

A way to allow clients to update packages by themselves is required, otherwise a situation like this will occur:

  • Latest microsoft.securityessentials in win_repo is 4.4.304.0.
  • Client updates through Windows Update to 4.5.216.0.
  • Applying the state for this client results in:
          ID: microsoft.securityessentials
    Function: pkg.installed
      Result: False
     Comment: The following packages failed to install/update: microsoft.securityessentials=4.4.304.0.
     Changes:
@UtahDave UtahDave self-assigned this Mar 27, 2014
@UtahDave
Copy link
Contributor

Thanks for opening this issue. I've assigned it to myself.

I think this totally makes sense.

@basepi basepi added the Feature label Mar 28, 2014
@basepi basepi added this to the Approved for future release milestone Mar 28, 2014
@UtahDave
Copy link
Contributor

UtahDave commented Apr 1, 2014

Hm. This isn't a Windows specific issue. I think all OSes will exhibit this same behavior. @terminalmage what do you think the proper behavior should be in this type of situation?

@terminalmage
Copy link
Contributor

No, this isn't something that is a problem for other platforms. @eliasp I'm guessing you're pinning the version number in your SLS file? It'd be helpful if you posted the actual SLS you're using, as well as the version of Salt you are running. This is actually pretty basic troubleshooting information, without which it can be difficult to narrow down the issue.

@eliasp
Copy link
Contributor Author

eliasp commented Apr 2, 2014

Sorry for leaving out some details.
I'm not pinning the version, using only this SLS:

microsoft.securityessentials:
    pkg:
        - installed

Master is on 2014.0
Minion is on 2014.1 (amd64, Win 7 Enterprise, en_US)

The win_repo definition for microsoft.securityessentials:

microsoft.securityessentials:
    4.4.304.0:
        installer: http://mse.dlservice.microsoft.com/download/A/3/8/A38FFBF2-1122-48B4-AF60-E44F6DC28BD8/enus/amd64/mseinstall.exe
        full_name: Microsoft Security Essentials 
        reboot: False
        install_flags: ' /s /runwgacheck'
        msiexec: False
        uninstaller: '%PROGRAMFILES%/Microsoft Security Client/Setup.exe'
        uninstall_flags: ' /s /u'

@eliasp
Copy link
Contributor Author

eliasp commented May 10, 2014

Fixed in #12670

@eliasp eliasp closed this as completed May 10, 2014
@eliasp
Copy link
Contributor Author

eliasp commented May 10, 2014

I was wrong - re-opening + working on a fix.

@eliasp eliasp reopened this May 10, 2014
eliasp added a commit to eliasp/salt that referenced this issue May 12, 2014
In some cases, it is required to let packages update themselves:
- Some Windows updates increase the version number of installed packages
  while this version cannot be deployed standalone through a regular
  win_repo package
- Allow users to apply timely critical updates on their own so they
  don't have to wait for the admins to provide the newest version (e.g
  auto updates of software such as Mozilla Firefox which allows to
  install updates through regular users without administrative
  permissions)

Fixes saltstack#11602
@jfindlay jfindlay added Platform Relates to OS, containers, platform-based utilities like FS, system based apps and removed Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps State-Module Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants