-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow packages to be updated on their own #12711
Conversation
In some cases, it is required to let packages update themselves: - Some Windows updates increase the version number of installed packages while this version cannot be deployed standalone through a regular win_repo package - Allow users to apply timely critical updates on their own so they don't have to wait for the admins to provide the newest version (e.g auto updates of software such as Mozilla Firefox which allows to install updates through regular users without administrative permissions) Fixes saltstack#11602
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Test FAILed. |
if not _fulfills_version_spec(cver, comparison, verstr): | ||
# Current version did not match desired, add to targets | ||
log.debug('Current version ({0} did not match ({1}) desired ({2}), add to targets'.format(cver,comparison,verstr)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing lint errors:
http://jenkins.saltstack.com/job/salt-pr-lint/3863/violations/file/salt/states/pkg.py/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Maybe we should specify more clearly that this is just a windows thing in the pkg docs? |
@thatch45 Haven't tried this on Linux yet, but in general I think the same thing could apply to Linux environments where a user with local admin permissions updates a package on its own. |
Test PASSed. |
Test FAILed. |
Allow packages to be updated on their own
I see it better now, thanks for the clarification! |
In some cases, it is required to let packages update themselves:
while this version cannot be deployed standalone through a regular
win_repo package
don't have to wait for the admins to provide the newest version (e.g
auto updates of software such as Mozilla Firefox which allows to
install updates through regular users without administrative
permissions)
Fixes #11602