Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packages to be updated on their own #12711

Merged
merged 2 commits into from
May 13, 2014

Conversation

eliasp
Copy link
Contributor

@eliasp eliasp commented May 12, 2014

In some cases, it is required to let packages update themselves:

  • Some Windows updates increase the version number of installed packages
    while this version cannot be deployed standalone through a regular
    win_repo package
  • Allow users to apply timely critical updates on their own so they
    don't have to wait for the admins to provide the newest version (e.g
    auto updates of software such as Mozilla Firefox which allows to
    install updates through regular users without administrative
    permissions)

Fixes #11602

In some cases, it is required to let packages update themselves:
- Some Windows updates increase the version number of installed packages
  while this version cannot be deployed standalone through a regular
  win_repo package
- Allow users to apply timely critical updates on their own so they
  don't have to wait for the admins to provide the newest version (e.g
  auto updates of software such as Mozilla Firefox which allows to
  install updates through regular users without administrative
  permissions)

Fixes saltstack#11602
@ghost
Copy link

ghost commented May 12, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4276/

@ghost
Copy link

ghost commented May 12, 2014

Test FAILed.
Refer to this link for build results: http://cookingwithsalt.org/job/salt/job/pr/job/build/35181/

if not _fulfills_version_spec(cver, comparison, verstr):
# Current version did not match desired, add to targets
log.debug('Current version ({0} did not match ({1}) desired ({2}), add to targets'.format(cver,comparison,verstr))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@thatch45
Copy link
Contributor

Maybe we should specify more clearly that this is just a windows thing in the pkg docs?

@eliasp
Copy link
Contributor Author

eliasp commented May 13, 2014

@thatch45 Haven't tried this on Linux yet, but in general I think the same thing could apply to Linux environments where a user with local admin permissions updates a package on its own.

@ghost
Copy link

ghost commented May 13, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4302/

@ghost
Copy link

ghost commented May 13, 2014

Test FAILed.
Refer to this link for build results: http://cookingwithsalt.org/job/salt/job/pr/job/build/35205/

thatch45 added a commit that referenced this pull request May 13, 2014
Allow packages to be updated on their own
@thatch45 thatch45 merged commit 998b3cc into saltstack:develop May 13, 2014
@thatch45
Copy link
Contributor

I see it better now, thanks for the clarification!

@eliasp eliasp deleted the states_pkg-allow_updates branch May 14, 2014 21:25
@eliasp eliasp mentioned this pull request May 18, 2016
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow packages on Windows client to be newer than latest in win_repo
2 participants