Reimplemented 'latest_version()' to fix #12663 and make it more readable + better debug-able.

[eliasp]

`latest_version' caused some trouble as outlined in #12663

Part of the problem was not using versions_as_list=True for retrieving the list of installed package (resulting in version strings of joined single versions like 15.0.4420.1017,15.0.4569.1506), but also a bit convoluted implementation.

This re-implementation works fine for me, but a review + test would be appreciated to make sure we don't break anything.

[ghost]

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4209/

[ghost]

Test FAILed.
Refer to this link for build results: http://cookingwithsalt.org/job/salt/job/pr/job/build/24754/

[thatch45]

@UtahDave can you please take a look here? At first glance it all looks good, but you are the man here

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4344/

[ghost]

Test FAILed.
Refer to this link for build results: http://cookingwithsalt.org/job/salt/job/pr/job/build/43952/

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4345/

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4346/

[ghost]

Test FAILed.
Refer to this link for build results: http://cookingwithsalt.org/job/salt/job/pr/job/build/43953/

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4347/

[ghost]

Test FAILed.
Refer to this link for build results: http://cookingwithsalt.org/job/salt/job/pr/job/build/43954/

[thatch45]

Sorry about the wait here @eliasp, @UtahDave has been swamped and he should be able to get to this later this week

[eliasp]

@thatch45 No problem… the wait was actually worth it and the PR had to ripen a bit. Found a bug which I fixed and git push --forced in the meantime :)

[eliasp]

Any updates on a review for this one? I'd like to make sure this goes into Helium as fix for #12663.

[UtahDave]

Yeah, I'll test this morning. Thanks for your work on this!
On May 24, 2014 6:33 AM, "Elias Probst" notifications@github.com wrote:

Any updates on this one? I'd like to make sure this goes into Helium as
fix for #12663 #12663.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12670#issuecomment-44085836
.