-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add android NDK event loop #1556
Conversation
Great work thanks! |
@JasperDeSutter can you add the ci changes to this PR too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JasperDeSutter it's on my todo list to merge before end of the week, let's just give it a couple more days incase someone wants to comment. |
Okay, sounds great! |
Needs rebasing. I'm wondering if it makes sense to add the ndk glue to all examples. #[cfg(target_os = "android")]
ndk_glue::ndk_glue!(main); The other issue is that android apps rely on |
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to usersThese are not my changes, this backports the work (goddessfreya#2) of @dvc94ch to winit master. I have no issue if they want to take over this PR.
Running an example on an android device needs a couple things, add this to Cargo.toml:
And add this to the example file:
Now start the application with
cargo apk run --example request_redraw_threaded
Closes #721, closes #789, closes #948 cc @katyo