Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android #1421

Closed
wants to merge 14 commits into from
Closed

Android #1421

wants to merge 14 commits into from

Conversation

j4qfrost
Copy link
Contributor

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@j4qfrost
Copy link
Contributor Author

@dvc94ch committed the suggested changes

@j4qfrost j4qfrost mentioned this pull request Jan 28, 2020
@dvc94ch
Copy link
Member

dvc94ch commented Jan 28, 2020

This pr would need to be rebased and the android work completed. There are still issues with orientation changes. The deviceid change should be a separate PR as it's unrelated. Also the changes are not complete, you'd have to add the method to all backends.

@goddessfreya goddessfreya added DS - android C - waiting on author Waiting for a response or another PR labels Jan 28, 2020
@goddessfreya
Copy link
Contributor

goddessfreya commented Jan 28, 2020

As mentioned above, I'm confused as to why a Android PR is touching files in src/platform_impl/linux/**. The DeviceId changes seem to me to be unrelated to the Android ones.

@dvc94ch
Copy link
Member

dvc94ch commented May 3, 2020

Closing in favor of #1556

@dvc94ch dvc94ch closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on author Waiting for a response or another PR DS - android
Development

Successfully merging this pull request may close these issues.

3 participants