Basic android event loop 2.0 #2

dvc94ch · 2020-02-05T19:53:43Z

Tested on all platforms changed
Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created an example program if it would help users understand this functionality

goddessfreya · 2020-02-06T03:50:18Z

Are there are still issues with orientation changes? Can we get android added to the CI?

dvc94ch · 2020-02-06T17:40:10Z

Are there are still issues with orientation changes?

Not yet. Had to get it working again with the 0.23 branch first, I'll look into it next.

goddessfreya

https://github.com/goddessfreya/winit/pull/2/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR18-R23

Those lines should be moved to # Unreleased

CHANGELOG.md

src/platform_impl/linux/wayland/event_loop.rs

dvc94ch · 2020-02-08T20:11:47Z

This is a pretty important one that's not fixed yet rust-windowing#789

dvc94ch · 2020-02-10T16:53:03Z

cc @katyo

katyo · 2020-02-12T06:51:40Z

@dvc94ch I completely confused... How can I test it for now?

goddessfreya

Needs a rebase

dvc94ch · 2020-02-12T10:36:08Z

@katyo I created a repo with an example called android-no-glue.
first you need to clone the following repos:

https://github.com/dvc94ch/android-ndk-rs branch=android-glue
https://github.com/dvc94ch/android-no-glue
https://github.com/goddessfreya/gbm.rs branch=glutin-fun
https://github.com/dvc94ch/glutin branch=glutin0.23-android
https://github.com/rust-windowing/glutin_interface
https://github.com/rust-windowing/glutin_sys
https://github.com/rust-windowing/glutin_x11_sym
https://github.com/dvc94ch/winit branch=winit-glutin-next-android
https://github.com/rust-windowing/winit_types

then you need to install the new cargo-ndk:

cargo install --path android-ndk-rs/cargo-ndk

then you can build and run the android-no-glue example with:

cargo ndk run --target aarch64-linux-android

dvc94ch · 2020-02-12T23:22:49Z

@katyo did you get it to work? cargo-ndk still needs some work, some values are still hardcoded instead of parsed from the manifest, it doesn't resolving libraries recursively, doesn't emit fat binaries and doesn't support examples that work on desktop and mobile (as cargo does not support target specific crate-type)

katyo · 2020-02-13T06:28:13Z

@dvc94ch Thanks for expl.
Pls, fix winit-windowing to rust-windowing in repository urls

katyo · 2020-02-13T06:33:20Z

Unfortunately I cannot get it work due to linking errors:

error: linking with `...androidenv/ndk/20.1.5948944/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android29-clang` failed: exit code: 1

And error like a:

...android/android-no-glue/target/aarch64-linux-android/debug/deps/liblibloading-b99b21efde076db4.rlib: error adding symbols: File in wrong format

Same error with "--target arm-linux-androideabi":

...androidenv/ndk/20.1.5948944/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: ...android/android-no-glue/target/arm-linux-androideabi/debug/deps/liblibloading-3d5325302b343522.rlib(global_static.o): incompatible target
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

It seems something wrong with cargo ndk.
But I already used this tool for building shared libs for android and it works.

dvc94ch · 2020-02-13T07:01:54Z

cargo-ndk is ridiculously simple, the entire build logic is below, so I'm a bit confused how that's happening. Can you post the entire build log?

if let Some(triple) = target {
        let clang = ndk.clang(triple, manifest.target_sdk_version)?;
        cargo.env(cargo_env_target_cfg("LINKER", triple), &clang);

        let ar = ndk.toolchain_bin("ar", triple)?;
        cargo.env(cargo_env_target_cfg("AR", triple), &ar);
    }

    if cargo_cmd == "build" || cargo_cmd == "run" {
        cargo.arg("build").args(&cargo_args).status()?;
    }

EDIT: Did a clean build and there does seem to be some issues

katyo · 2020-02-13T07:45:17Z

I may mistake but it seems some important env vars is unset:

TARGET = Some("armv7-linux-androideabi")
OPT_LEVEL = Some("0")
HOST = Some("x86_64-unknown-linux-gnu")
CC_armv7-linux-androideabi = None # should be set!
CC_armv7_linux_androideabi = None
TARGET_CC = None
CC = Some("gcc") # wrong value!
CFLAGS_armv7-linux-androideabi = None
CFLAGS_armv7_linux_androideabi = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("true")
CARGO_CFG_TARGET_FEATURE = None

As I know the cargo apk sets CC with appropriate C compiler.

dvc94ch · 2020-02-13T10:39:48Z

Sry I'm a bit slow today, I've got a hangover. cargo-ndk is updated

katyo · 2020-02-13T12:06:08Z

@dvc94ch How can I specify min sdk version?

dvc94ch · 2020-02-13T13:50:17Z

@katyo Just finished implementing Cargo.toml parsing and fat binaries. It should work the same as cargo-apk. Only things missing is running bin/examples and porting your patch to recursively find libraries.

katyo · 2020-02-13T17:01:22Z

I able to build it but I have an error:

    Finished dev [unoptimized + debuginfo] target(s) in 24.10s
 'lib/arm64-v8a/libandroid_no_glue.so'...
Verifying alignment of ...android/android-no-glue/target/debug/ndk/android-no-glue.apk (4)...
      49 AndroidManifest.xml (OK - compressed)
     955 lib/arm64-v8a/libandroid_no_glue.so (OK - compressed)
Verification succesful
Error: Io(Os { code: 2, kind: NotFound, message: "No such file or directory" })

The apk is built but it seems the signing failed so I cannot install it:

adb: failed to install target/debug/ndk/android-no-glue.apk: Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES: Failed to collect certificates from /data/app/vmdl534534027.tmp/base.apk: Attempt to get length of null array]

dvc94ch · 2020-02-13T18:15:02Z

Mmh, what os are you using? Looks like we're nearly there :) I rebased cargo-ndk as it's feature complete. Now onto ironing out the bugs...

What happens if you update to latest master and remove ~/.android/debug.keystore?

Finished dev [unoptimized + debuginfo] target(s) in 0.02s
 'lib/arm64-v8a/libhello_world.so'...
Verifying alignment of /home/dvc/android/android-ndk-rs/target/debug/ndk/examples/hello_world/android-examples.apk (4)...
      49 AndroidManifest.xml (OK - compressed)
     961 lib/arm64-v8a/libhello_world.so (OK - compressed)
Verification succesful
Generating 2,048 bit RSA key pair and self-signed certificate (SHA256withRSA) with a validity of 10,000 days
	for: CN=Android Debug, O=Android, C=US
[Storing /home/dvc/.android/debug.keystore]

katyo · 2020-02-13T19:24:55Z

I use nixos, if this matter.

Verifying alignment of ...android/android-no-glue/target/debug/ndk/android-no-glue.apk (4)...
      49 AndroidManifest.xml (OK - compressed)
     955 lib/arm64-v8a/libandroid_no_glue.so (OK - compressed)
Verification succesful
Generating 2 048 bit RSA key pair and self-signed certificate (SHA256withRSA) with a validity of 10 000 days
        for: CN=Android Debug, O=Android, C=US
[Storing /home/kayo/.android/debug.keystore]

Warning:
The JKS keystore uses a proprietary format. It is recommended to migrate to PKCS12 which is an industry standard format using "keytool -importkeystore -srckeystore /home/kayo/.android/debug.keystore -destkeystore /home/kayo/.android/debug.keystore -deststoretype pkcs12".
Error: Io(Os { code: 2, kind: NotFound, message: "No such file or directory" })

katyo · 2020-02-13T19:28:33Z

It still not installable:

$ adb install target/debug/ndk/android-no-glue.apk
adb: failed to install target/debug/ndk/android-no-glue.apk: Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES: Failed to collect certificates from /data/app/vmdl169659180.tmp/base.apk: Attempt to get length of null array]

[nix-shell:...android/android-no-glue]$ l target/debug/ndk/*.apk
-rw-r--r-- 1 kayo users 3,0M feb 14 00:25 target/debug/ndk/android-no-glue.apk
-rw-r--r-- 1 kayo users 3,0M feb 14 00:25 target/debug/ndk/android-no-glue-unaligned.apk

dvc94ch · 2020-02-13T19:38:46Z

The weird thing is that we check that apksigner exists and then we fail with file not found. Is it possible that apksigner is a symlink? If that's the case it should be fixed now

katyo · 2020-02-13T19:56:42Z

Oh, It seems I forget patch android sdk executables after upgrading :)
It works!

.github/workflows/ci.yml

Cargo.toml

goddessfreya

Can winit's readme be amended with instructions for building the examples on android?

dvc94ch · 2020-02-17T20:00:46Z

Due to rust-lang/cargo#4881 saddly there's no good way to do it. I considered fixing it but it would likely be years behind a feature gate if the PR even gets accepted, so I decided it's not worth it.

dvc94ch · 2020-04-21T00:23:18Z

@Osspial so this one builds on the glutin 0.23 work. but it doesn't look like that's going anywhere for the time being as the windows and mac os x backends are missing. Should I backport it to winit master?

Osspial · 2020-04-21T20:08:51Z

@Osspial so this one builds on the glutin 0.23 work. but it doesn't look like that's going anywhere for the time being as the windows and mac os x backends are missing. Should I backport it to winit master?

👍 that seems like the right call.

dvc94ch mentioned this pull request Feb 5, 2020

Basic android event loop 2.0 rust-windowing/winit#1328

Closed

8 tasks

dvc94ch force-pushed the winit-glutin-next-android branch from 07f552c to e179a70 Compare February 6, 2020 21:41

goddessfreya requested changes Feb 8, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

src/platform_impl/linux/wayland/event_loop.rs Show resolved Hide resolved

dvc94ch force-pushed the winit-glutin-next-android branch from 60c8611 to 78f7210 Compare February 10, 2020 16:50

dvc94ch requested a review from goddessfreya February 10, 2020 16:52

goddessfreya force-pushed the winit-glutin-next branch from 54924ef to a56ee31 Compare February 11, 2020 06:21

goddessfreya requested changes Feb 12, 2020

View reviewed changes

dvc94ch force-pushed the winit-glutin-next-android branch 2 times, most recently from 4759911 to 8cc2fc3 Compare February 12, 2020 09:51

dvc94ch force-pushed the winit-glutin-next-android branch 4 times, most recently from 3fbabd3 to 66566ab Compare February 17, 2020 17:45

dvc94ch commented Feb 17, 2020

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

dvc94ch force-pushed the winit-glutin-next-android branch from 66566ab to fe582a8 Compare February 17, 2020 19:34

dvc94ch requested a review from goddessfreya February 17, 2020 19:35

dvc94ch added 3 commits February 17, 2020 20:49

Android event loop.

7cf47b7

Emit Suspend/Resume.

a21bd5a

Use paths.

f316104

dvc94ch force-pushed the winit-glutin-next-android branch from fe582a8 to 7cf47b7 Compare February 17, 2020 19:51

goddessfreya requested changes Feb 17, 2020

View reviewed changes

Fix panic on exit.

87f5cf3

dvc94ch mentioned this pull request Apr 30, 2020

Issues with cargo-apk + winit 0.19.0 rust-mobile/android-rs-glue#264

Open

JasperDeSutter mentioned this pull request May 3, 2020

add android NDK event loop rust-windowing/winit#1556

Merged

8 tasks

dvc94ch closed this May 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic android event loop 2.0 #2

Basic android event loop 2.0 #2

dvc94ch commented Feb 5, 2020

goddessfreya commented Feb 6, 2020

dvc94ch commented Feb 6, 2020

goddessfreya left a comment

dvc94ch commented Feb 8, 2020

dvc94ch commented Feb 10, 2020

katyo commented Feb 12, 2020

goddessfreya left a comment

dvc94ch commented Feb 12, 2020 •

edited

Loading

dvc94ch commented Feb 12, 2020 •

edited

Loading

katyo commented Feb 13, 2020

katyo commented Feb 13, 2020 •

edited

Loading

dvc94ch commented Feb 13, 2020 •

edited

Loading

katyo commented Feb 13, 2020 •

edited

Loading

dvc94ch commented Feb 13, 2020

katyo commented Feb 13, 2020

dvc94ch commented Feb 13, 2020

katyo commented Feb 13, 2020

dvc94ch commented Feb 13, 2020 •

edited

Loading

katyo commented Feb 13, 2020

katyo commented Feb 13, 2020

dvc94ch commented Feb 13, 2020 •

edited

Loading

katyo commented Feb 13, 2020

goddessfreya left a comment •

edited

Loading

dvc94ch commented Feb 17, 2020

dvc94ch commented Apr 21, 2020 •

edited

Loading

Osspial commented Apr 21, 2020

Basic android event loop 2.0 #2

Basic android event loop 2.0 #2

Conversation

dvc94ch commented Feb 5, 2020

goddessfreya commented Feb 6, 2020

dvc94ch commented Feb 6, 2020

goddessfreya left a comment

Choose a reason for hiding this comment

dvc94ch commented Feb 8, 2020

dvc94ch commented Feb 10, 2020

katyo commented Feb 12, 2020

goddessfreya left a comment

Choose a reason for hiding this comment

dvc94ch commented Feb 12, 2020 • edited Loading

dvc94ch commented Feb 12, 2020 • edited Loading

katyo commented Feb 13, 2020

katyo commented Feb 13, 2020 • edited Loading

dvc94ch commented Feb 13, 2020 • edited Loading

katyo commented Feb 13, 2020 • edited Loading

dvc94ch commented Feb 13, 2020

katyo commented Feb 13, 2020

dvc94ch commented Feb 13, 2020

katyo commented Feb 13, 2020

dvc94ch commented Feb 13, 2020 • edited Loading

katyo commented Feb 13, 2020

katyo commented Feb 13, 2020

dvc94ch commented Feb 13, 2020 • edited Loading

katyo commented Feb 13, 2020

goddessfreya left a comment • edited Loading

Choose a reason for hiding this comment

dvc94ch commented Feb 17, 2020

dvc94ch commented Apr 21, 2020 • edited Loading

Osspial commented Apr 21, 2020

dvc94ch commented Feb 12, 2020 •

edited

Loading

dvc94ch commented Feb 12, 2020 •

edited

Loading

katyo commented Feb 13, 2020 •

edited

Loading

dvc94ch commented Feb 13, 2020 •

edited

Loading

katyo commented Feb 13, 2020 •

edited

Loading

dvc94ch commented Feb 13, 2020 •

edited

Loading

dvc94ch commented Feb 13, 2020 •

edited

Loading

goddessfreya left a comment •

edited

Loading

dvc94ch commented Apr 21, 2020 •

edited

Loading