-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic android event loop 2.0 #1328
Conversation
@dvc94ch Curiously, but sometimes instant is less than start, so panic occurs here. let duration = if instant <= start { Duration::default() } else { instant - start };
first_event = convert(looper.poll_all_timeout(duration).unwrap()); the demo runs fine. |
@dvc94ch It still has troubles with orientation change. Sometimes window size given in resize event is unusual (like 720x720, 1280x1280) and also several resize events happens on single orientation change. It seems we need workaround like delaying resize event from the moment when it actually happened. |
@katyo I'm having the same problem, it's driving me nuts :) |
@katyo I think I've fixed it, can you check if it works for you now? On a ConfigChange we rerender 10x in a 10ms interval and that works on my phone. |
@dvc94ch I tested on three different devices on from api level 16 to 28. Orientation change works fine everywhere! |
I think this will probably need changes in the future, but it's enough of an improvement on the status quo that it should be merged before it gets stale. |
@dvc94ch Unfortunately it still work too buggy. In particular after recent commit. |
Going forward, who's going to be responsible for maintaining the Android backend? There aren't any listed maintainers in the wiki document, and having a backend without active developers working on it makes it difficult for Winit's API to evolve. |
It's my intention of maintaining it, I'm just currently distracted with https://github.com/flutter-rs/cargo-flutter and will get back to this in a couple of days. |
Also I in a process of implementing some missing features related to user interaction. |
@katyo did you resolve the SIGABRT issue? I'm having the same problem when trying to call |
@dvc94ch: I don't sure, but, it seems, SIGABRT gone away after I fixed pointer to activity object. |
Closing in favor of goddessfreya#2 |
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to users