Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: Update LLVM to fix a test #46401

Merged
merged 1 commit into from
Dec 2, 2017
Merged

Conversation

alexcrichton
Copy link
Member

This commit updates LLVM with some tweaks to the integer <-> floating point
conversion instructions to ensure that as in Rust doesn't trap.

Closes #46298

This commit updates LLVM with some tweaks to the integer <-> floating point
conversion instructions to ensure that `as` in Rust doesn't trap.

Closes rust-lang#46298
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2017
@arielb1
Copy link
Contributor

arielb1 commented Nov 30, 2017

Don't you need to update llvm-rebuild-trigger?

@alexcrichton
Copy link
Member Author

Nah not any more nowadays, we should probably remove that file...

@arielb1
Copy link
Contributor

arielb1 commented Nov 30, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2017

📌 Commit 666bb90 has been approved by arielb1

kennytm added a commit to kennytm/rust that referenced this pull request Dec 1, 2017
wasm: Update LLVM to fix a test

This commit updates LLVM with some tweaks to the integer <-> floating point
conversion instructions to ensure that `as` in Rust doesn't trap.

Closes rust-lang#46298
bors added a commit that referenced this pull request Dec 1, 2017
Rollup of 13 pull requests

- Successful merges: #45880, #46280, #46373, #46376, #46385, #46386, #46387, #46392, #46400, #46401, #46405, #46412, #46421
- Failed merges:
@bors bors merged commit 666bb90 into rust-lang:master Dec 2, 2017
@alexcrichton alexcrichton deleted the wasm-tests branch December 2, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants