Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Fix a typo with the Cargo book #46385

Merged
merged 1 commit into from
Dec 2, 2017

Conversation

alexcrichton
Copy link
Member

The usage of Path::new prevented out-of-tree builds (like the bots do) from
working by accident!

Closes #46195

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 29, 2017

📌 Commit 326eb79 has been approved by Mark-Simulacrum

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 30, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
arielb1 pushed a commit to arielb1/rust that referenced this pull request Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
@frewsxcv
Copy link
Member

frewsxcv commented Dec 1, 2017

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Dec 1, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
bors added a commit that referenced this pull request Dec 1, 2017
Rollup of 13 pull requests

- Successful merges: #45880, #46280, #46373, #46376, #46385, #46386, #46387, #46392, #46400, #46401, #46405, #46412, #46421
- Failed merges:
@bors bors merged commit 326eb79 into rust-lang:master Dec 2, 2017
@alexcrichton alexcrichton deleted the fix-cargo-book branch January 23, 2018 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants