-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rustdoc item summaries that are headers #46387
Conversation
Rustoc item summaries that are headers were not displayed at all because they started with whitespace. This PR fixes this and now removes the whitespace and then displays the block.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks so much for writing this! r=me if Travis goes green. |
@bors r+ All looks good to me! Travis checked out, so it looks like the test passes. Thanks again! |
📌 Commit 91a4106 has been approved by |
Thanks for walking me through this! :) |
There was some mishaps with commits here, so let me make sure bors sees this PR correctly... @bors r+ |
📌 Commit 91a4106 has been approved by |
@bors rollup |
Fix rustdoc item summaries that are headers Rustoc item summaries that are headers were not displayed at all because they started with whitespace. This PR fixes this and now removes the whitespace and then displays the block. I'm not sure if the rustdoc test is written correctly, if there's anything to improve, just let me know. :) This fixes rust-lang#46377. This is how it looks when rendered out now: ![Rendered](https://i.imgur.com/7u8jUAM.png)
Rustoc item summaries that are headers were not displayed at all because
they started with whitespace.
This PR fixes this and now removes the whitespace and then displays the
block.
I'm not sure if the rustdoc test is written correctly, if there's anything to improve, just let me know. :)
This fixes #46377.
This is how it looks when rendered out now: