Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Ensure cargo links libcurl statically #40507

Merged
merged 1 commit into from
Mar 18, 2017

Conversation

alexcrichton
Copy link
Member

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

This is a regession from nightly, so nominating for beta as well.

@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Mar 14, 2017
@brson
Copy link
Contributor

brson commented Mar 14, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit 5fab9bf has been approved by brson

@alexcrichton
Copy link
Member Author

@bors: p=1

(fixing nightly)

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 14, 2017
@bors
Copy link
Contributor

bors commented Mar 15, 2017

⌛ Testing commit 5fab9bf with merge 6d38130...

@bors
Copy link
Contributor

bors commented Mar 15, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: retry

@Arzte
Copy link
Contributor

Arzte commented Mar 15, 2017

@alexcrichton Looks like bors failed, could you retry it?

@alexcrichton
Copy link
Member Author

@SirDoctors ah yeah that's what my previous comment is doing.

bors added a commit that referenced this pull request Mar 16, 2017
[beta] travis: Ensure cargo links libcurl statically

This is a beta backport of #40507
@bors
Copy link
Contributor

bors commented Mar 16, 2017

⌛ Testing commit 5fab9bf with merge 12cc8da...

@bors
Copy link
Contributor

bors commented Mar 16, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

alexcrichton commented Mar 16, 2017 via email

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
travis: Ensure cargo links libcurl statically

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
travis: Ensure cargo links libcurl statically

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
@bors
Copy link
Contributor

bors commented Mar 17, 2017

⌛ Testing commit 5fab9bf with merge 2e540cd...

@bors
Copy link
Contributor

bors commented Mar 17, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@alexcrichton
Copy link
Member Author

@bors: retry

  • I... have no idea

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 17, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
travis: Ensure cargo links libcurl statically

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
travis: Ensure cargo links libcurl statically

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
bors added a commit that referenced this pull request Mar 17, 2017
[beta] Backports to beta

This is a backport of the following PRs to beta:

* #40507
* #40482
* #40526
* #40539
* #40538
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
travis: Ensure cargo links libcurl statically

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
@bors
Copy link
Contributor

bors commented Mar 18, 2017

⌛ Testing commit 5fab9bf with merge df3ab37...

bors added a commit that referenced this pull request Mar 18, 2017
travis: Ensure cargo links libcurl statically

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
@bors
Copy link
Contributor

bors commented Mar 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing df3ab37 to master...

@bors bors merged commit 5fab9bf into rust-lang:master Mar 18, 2017
@Arzte
Copy link
Contributor

Arzte commented Mar 18, 2017

woot!

@alexcrichton alexcrichton deleted the static-libcurl branch March 20, 2017 14:48
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants