Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] travis: Ensure cargo links libcurl statically #40525

Closed
wants to merge 2 commits into from

Conversation

alexcrichton
Copy link
Member

This is a beta backport of #40507

We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton
Copy link
Member Author

@bors: r=brson p=2

(fixing beta)

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit 00722bb has been approved by brson

@bors
Copy link
Contributor

bors commented Mar 15, 2017

⌛ Testing commit 00722bb with merge e94a430...

@bors
Copy link
Contributor

bors commented Mar 15, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

@bors: retry

@alexcrichton
Copy link
Member Author

@bors: retry

@bors
Copy link
Contributor

bors commented Mar 15, 2017

⌛ Testing commit 00722bb with merge 3bb0476...

@bors
Copy link
Contributor

bors commented Mar 16, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: retry

  • osx timeout?

@bors
Copy link
Contributor

bors commented Mar 16, 2017

⌛ Testing commit 00722bb with merge e9b10f9...

bors added a commit that referenced this pull request Mar 16, 2017
[beta] travis: Ensure cargo links libcurl statically

This is a beta backport of #40507
@bors
Copy link
Contributor

bors commented Mar 16, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors
Copy link
Contributor

bors commented Mar 16, 2017

⌛ Testing commit 00722bb with merge 885250f...

@bors
Copy link
Contributor

bors commented Mar 16, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors
Copy link
Contributor

bors commented Mar 17, 2017

⌛ Testing commit 00722bb with merge 9db6fda...

@frewsxcv
Copy link
Member

@bors retry

prioritizing the rollup which includes these changes #40591

@bors
Copy link
Contributor

bors commented Mar 17, 2017

⌛ Testing commit 00722bb with merge 4535b3a...

@frewsxcv
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 17, 2017

⌛ Testing commit 00722bb with merge c3b906e...

@bors
Copy link
Contributor

bors commented Mar 17, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

The job has been terminated

Looks like we blew the 4MB cap, so let's hide some more output.
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Mar 17, 2017

📌 Commit 2b145f7 has been approved by brson

@alexcrichton
Copy link
Member Author

gonna make a new PR with more backports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants