Removes Default for Box<Path>. #40539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #40009) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
added
beta-accepted
|
Looks great to me, thanks! r=me with a rebase |
clarfonthey
force-pushed
the
no_default_path
branch
from
8600ccf
to
5e2d592
Compare
|
Just rebased, should work now! |
|
@bors: r+ p=1 (beta nominated) |
|
📌 Commit 5e2d592 has been approved by |
|
@clarcharr according to #40550 a test may need an update as well? |
clarfonthey
force-pushed
the
no_default_path
branch
from
5e2d592
to
0739ece
Compare
|
Oh, whoops. Updated the PR. |
|
@bors: r+ |
|
📌 Commit 0739ece has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
bors
added a commit
that referenced
this pull request
Mar 17, 2017
Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not supposed to be added. cc @alexcrichton