Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to .editorconfig for Rust files #24948

Merged
merged 2 commits into from
May 10, 2015
Merged

link to .editorconfig for Rust files #24948

merged 2 commits into from
May 10, 2015

Conversation

derhuerst
Copy link
Contributor

I've written a small EditorConfig file for Rust development.

I've written a small [EditorConfig](http://editorconfig.org) file for Rust development.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

Thank you!

We've kept this list, so far, to just the officially distributed configurations. Could you maybe instead add a new section for community plugins, so that the distinction is clear?

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2015

📌 Commit 6f3641d has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks @derhuerst ! In the future, can you leave a comment when you update a PR? GitHub doesn't send notifications otherwise, so I wasn't aware that you'd fixed it :)

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
I've written a small [EditorConfig](http://editorconfig.org) file for Rust development.
bors added a commit that referenced this pull request May 10, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
I've written a small [EditorConfig](http://editorconfig.org) file for Rust development.
bors added a commit that referenced this pull request May 10, 2015
@bors bors merged commit 6f3641d into rust-lang:master May 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants