Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a precision for references issues in doc #25222

Merged
merged 2 commits into from
May 10, 2015
Merged

Add a precision for references issues in doc #25222

merged 2 commits into from
May 10, 2015

Conversation

GuillaumeGomez
Copy link
Member

steveklabnik
steveklabnik reviewed May 10, 2015
View reviewed changes
src/doc/trpl/references-and-borrowing.md

We get this error:

error: `x` does not live long enough
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs triple ticks and text

@steveklabnik
Copy link
Member

r= me after the nit

@GuillaumeGomez
Copy link
Member Author

I saw there were also missing backticks at line 316, I added them. In this, should I squash ?

@GuillaumeGomez
Copy link
Member Author

r= @steveklabnik

@steveklabnik
Copy link
Member

The r= only works if you have commit bit :)

Anyway, I think that I have already accepted a PR to add that other missing one, but let's just let homu sort it out :)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2015

📌 Commit 25543f3 has been approved by steveklabnik

@GuillaumeGomez
Copy link
Member Author

Ok haha. I wasn't sure about the r= you, so I tried :p

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
@steveklabnik
Rollup merge of rust-lang#25222 - GuillaumeGomez:doc-ref, r=steveklabnik
ba8eb58 
r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request May 10, 2015
Merged
bors added a commit that referenced this pull request May 10, 2015
@bors
Auto merge of #25281 - steveklabnik:rollup, r=steveklabnik
9ecc989 
- Successful merges: #24948, #25158, #25188, #25222, #25239, #25240, #25241, #25255, #25257, #25263
- Failed merges:
@bors bors merged commit 25543f3 into rust-lang:master May 10, 2015
@GuillaumeGomez GuillaumeGomez deleted the doc-ref branch June 24, 2015 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @steveklabnik @bors