Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: unwrap is discouraged, so use Some #25271

Merged
merged 1 commit into from
May 11, 2015
Merged

doc: unwrap is discouraged, so use Some #25271

merged 1 commit into from
May 11, 2015

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2015

📌 Commit dcdc50d has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
@steveklabnik
Rollup merge of rust-lang#25271 - tshepang:doc-deunwrap, r=steveklabnik
253612d
@steveklabnik steveklabnik mentioned this pull request May 10, 2015
Closed
bors added a commit that referenced this pull request May 10, 2015
@bors
Auto merge of #25275 - steveklabnik:rollup, r=steveklabnik
d9ec142 
- Successful merges: #24948, #25085, #25158, #25188, #25239, #25240, #25241, #25255, #25257, #25263, #25271
- Failed merges:
@steveklabnik
Copy link
Member

@bors: -rollup

@steveklabnik
Copy link
Member

@bors: rollup-

@steveklabnik
Copy link
Member

This seemed to cause the rollup to fail: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4880/steps/test/logs/stdio

@tshepang
Copy link
Member Author

fixed

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2015

📌 Commit 683da9c has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 10, 2015
@steveklabnik
Rollup merge of rust-lang#25271 - tshepang:doc-deunwrap, r=steveklabnik
21aa65f
@steveklabnik steveklabnik mentioned this pull request May 10, 2015
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request May 11, 2015
@Manishearth
Rollup merge of rust-lang#25271 - tshepang:doc-deunwrap, r=steveklabnik
8e4312b
@Manishearth Manishearth mentioned this pull request May 11, 2015
Closed
@bors
Copy link
Contributor

bors commented May 11, 2015

⌛ Testing commit 683da9c with merge af57ec5...

bors added a commit that referenced this pull request May 11, 2015
@bors
Auto merge of #25271 - tshepang:doc-deunwrap, r=steveklabnik
af57ec5
@bors
Copy link
Contributor

bors commented May 11, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit 683da9c into rust-lang:master May 11, 2015
@tshepang tshepang deleted the doc-deunwrap branch May 11, 2015 13:06
@steveklabnik steveklabnik mentioned this pull request May 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rust-highfive @steveklabnik @bors @pcwalton