Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of PRs in the queue; Thursday #24232

Merged
merged 51 commits into from
Apr 9, 2015
Merged

Commits on Apr 7, 2015

  1. Configuration menu
    Copy the full SHA
    da7529a View commit details
    Browse the repository at this point in the history
  2. Check casts from float

    sanxiyn committed Apr 7, 2015
    Configuration menu
    Copy the full SHA
    f4c2228 View commit details
    Browse the repository at this point in the history
  3. Check casts from fat pointer

    sanxiyn committed Apr 7, 2015
    Configuration menu
    Copy the full SHA
    d18b405 View commit details
    Browse the repository at this point in the history
  4. Add Clone impls for extern "C" and unsafe fns

    We only implemented Clone on `extern "Rust" fn`s (for up to 8
    parameters). This didn't cover `extern "C"` or `unsafe` (or `unsafe
    extern "C"`) `fn`s, but there's no reason why they shouldn't be
    cloneable as well.
    
    The new impls are marked unstable because the existing impl for `extern
    "Rust" fn`s is.
    
    Fixes rust-lang#24161.
    lilyball committed Apr 7, 2015
    Configuration menu
    Copy the full SHA
    df95719 View commit details
    Browse the repository at this point in the history
  5. Fix a typo

    omo committed Apr 7, 2015
    Configuration menu
    Copy the full SHA
    3344221 View commit details
    Browse the repository at this point in the history
  6. rustup: let RUSTUP_PREFIX env override default prefix.

    The idea here is if you don't want rust in /usr/local
    you can put something like this is your .profile:
    
    export RUSTUP_PREFIX=$HOME/.local/rust
    export PATH=$PATH:${RUSTUP_PREFIX}/bin
    export DYLD_LIBRARY_PATH=$DYLD_LIBRARY_PATH:${RUSTUP_PREFIX}/lib
    
    Then when you run rustup, it will update the install
    in ${RUSTUP_PREFIX} without having to remember to pass
    an explicit --prefix argument every time.
    rillian committed Apr 7, 2015
    Configuration menu
    Copy the full SHA
    9a51c63 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2015

  1. disabling a test that is failing on bitrig.

    Dave Huseby committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    5c3aa01 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a329a61 View commit details
    Browse the repository at this point in the history
  3. Address review comments

    sanxiyn committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    e2ff188 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    59e62de View commit details
    Browse the repository at this point in the history
  5. Modify the ExprUseVisitor to walk each part of an AutoRef, and in

    particular to treat an AutoUnsize as as kind of "instantaneous" borrow
    of the value being unsized. This prevents us from feeding uninitialized
    data.
    
    This caused a problem for the eager reborrow of comparison traits,
    because that wound up introducing a "double AutoRef", which was not
    being thoroughly checked before but turned out not to type check.
    Fortunately, we can just remove that "eager reborrow" as it is no longer
    needed now that `PartialEq` doesn't force both LHS and RHS to have the
    same type (and even if we did have this problem, the better way would be
    to lean on introducing a common supertype).
    nikomatsakis committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    1e79870 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    45eb54c View commit details
    Browse the repository at this point in the history
  7. configure: Remove obsolete --disable-verify option

    rust-installer never verifies.
    brson committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    bc9f16c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ed8eebd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    59e332b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2cdfd37 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8545d2c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1b34f0a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7cbf823 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0cb9379 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1002155 View commit details
    Browse the repository at this point in the history
  16. Auto merge of rust-lang#24144 - richo:ptr-formatter, r=alexcrichton

    ~~I believe this should fix the issue. Opening a PR to ensure noone duplicates effort, I'm running check now.~~
    
    Closes rust-lang#24091
    bors committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    6436e34 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6d17c35 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2a9e101 View commit details
    Browse the repository at this point in the history
  19. std: Destabilize the internals of panic!

    Now that we have a `#[allow_internal_unstable]` attribute for macros there's no
    need for these two `begin_unwind` functions to be stable. Right now the `panic!`
    interface is the only one we wish to stabilize, so remove the stability markers
    from these functions.
    
    While this is a breaking change, it is highly unlikely to break any actual code.
    It is recommended to use the `panic!` macro instead if it breaks explicit calls
    into `std::rt`.
    
    [breaking-change]
    cc rust-lang#24208
    alexcrichton committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    65e3f03 View commit details
    Browse the repository at this point in the history
  20. std: Stabilize Clone::clone_from

    This method hasn't really changed since is inception, and it can often be a
    nice performance win for some situations. This method also imposes no burden on
    implementors or users of `Clone` as it's just a default method on the side.
    alexcrichton committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    6b32072 View commit details
    Browse the repository at this point in the history
  21. std: Stabilize io::Error::from_raw_os_error

    This commit stabilizes the old `io::Error::from_os_error` after being renamed to
    use the `raw_os_error` terminology instead. This function is often useful when
    writing bindings to OS functions but only actually converting to an I/O error at
    a later point.
    alexcrichton committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    561fdec View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2015

  1. Remove pretty-expanded from failing tests

    This commit removes pretty-expanded from all tests that wind up calling panic!
    one way or another now that its internals are unstable.
    alexcrichton committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    ec7c800 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    287a544 View commit details
    Browse the repository at this point in the history
  3. Don't deoptimize llvm when --enable-debug

    libLTO fails to link here.
    brson committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    a725426 View commit details
    Browse the repository at this point in the history
  4. Implement io::Seek for io::BufReader<R> where R: io::Seek

    Seeking the `BufReader` discards the internal buffer (and adjusts the
    offset appropriately when seeking with `SeekFrom::Current(_)`).
    lilyball committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    0a380a9 View commit details
    Browse the repository at this point in the history
  5. Implement io::Seek for io::BufWriter<W> where W: io::Seek

    Seeking the `BufWriter` writes out its internal buffer before seeking.
    lilyball committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    1605205 View commit details
    Browse the repository at this point in the history
  6. Auto merge of rust-lang#24168 - kballard:clone-for-extern-c-unsafe-fn…

    …s, r=alexcrichton
    
    We only implemented Clone on `extern "Rust" fn`s (for up to 8
    parameters). This didn't cover `extern "C"` or `unsafe` (or
    `unsafe extern "C"`) `fn`s, but there's no reason why they shouldn't be
    cloneable as well.
    
    The new impls are marked unstable because the existing impl for `extern
    "Rust" fn`s is.
    
    Fixes rust-lang#24161.
    bors committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    0e5e669 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    613cf9a View commit details
    Browse the repository at this point in the history
  8. Fix the span for for expressions

    nrc committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    341870a View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#24171 - rillian:rustup, r=brson

     The idea here is if you don't want rust in /usr/local
    you can put something like this is your .profile:
    
    ```
    export RUSTUP_PREFIX=$HOME/.local/rust
    export PATH=$PATH:${RUSTUP_PREFIX}/bin
    export DYLD_LIBRARY_PATH=$DYLD_LIBRARY_PATH:${RUSTUP_PREFIX}/lib
    ```
    Then when you run rustup, it will update the install
    in ${RUSTUP_PREFIX} without having to remember to pass
    an explicit --prefix argument every time.
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    ce76589 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#24175 - dhuseby:bitrig_fixing_tests_2, r=al…

    …excrichton
    
     I'm not sure why this is failing.  This patch disables this test until I can figure out what is wrong.
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    a00ab58 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    68100e4 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#24191 - nikomatsakis:issue-20791, r=pnkfelix

     Modify the ExprUseVisitor to walk each part of an AutoRef, and in
    particular to treat an AutoUnsize as as kind of \"instantaneous\" borrow
    of the value being unsized. This prevents us from feeding uninitialized
    data.
    
    This caused a problem for the eager reborrow of comparison traits,
    because that wound up introducing a \"double AutoRef\", which was not
    being thoroughly checked before but turned out not to type check.
    Fortunately, we can just remove that \"eager reborrow\" as it is no longer
    needed now that `PartialEq` doesn't force both LHS and RHS to have the
    same type (and even if we did have this problem, the better way would be
    to lean on introducing a common supertype).
    
    Fixes rust-lang#20791.
    
    r? @nrc
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    3b87140 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    67fa4d3 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#24205 - brson:debug, r=alexcrichton

     This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per rust-lang#17665. It does not add a `--enable-release` flag since that would be a no-op.
    
    cc @nrc
    
    Fixes rust-lang#22390
    Fixes rust-lang#17081
    Partially addresses rust-lang#17665
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    2dffe78 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#24207 - kmcallister:llvm-plugin, r=brson

     r? @brson
    
    I'm using this to integrate rustc with [american-fuzzy-lop](http://lcamtuf.coredump.cx/afl/). Building with afl instrumentation is no different from loading any other plugin library.
    
    I'd like this PR to include a `run-make` test with a custom LLVM pass; however I'm not sure it's worth the trouble of building C++ code and linking LLVM from the test suite (are there existing tests that do this?)
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    4e466e7 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#24212 - alexcrichton:destabilize-begin-unwi…

    …nd, r=huonw
    
     Now that we have a `#[allow_internal_unstable]` attribute for macros there's no
    need for these two `begin_unwind` functions to be stable. Right now the `panic!`
    interface is the only one we wish to stabilize, so remove the stability markers
    from these functions.
    
    While this is a breaking change, it is highly unlikely to break any actual code.
    It is recommended to use the `panic!` macro instead if it breaks explicit calls
    into `std::rt`.
    
    [breaking-change]
    cc rust-lang#24208
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    5daee19 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#24215 - alexcrichton:stabilize-clone-from, …

    …r=aturon
    
     This method hasn't really changed since is inception, and it can often be a
    nice performance win for some situations. This method also imposes no burden on
    implementors or users of `Clone` as it's just a default method on the side.
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    cdfbb11 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#24216 - alexcrichton:stabilize-from-raw-os-…

    …error, r=aturon
    
     This commit stabilizes the old `io::Error::from_os_error` after being renamed to
    use the `raw_os_error` terminology instead. This function is often useful when
    writing bindings to OS functions but only actually converting to an I/O error at
    a later point.
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    1a6e100 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#24218 - lstat:remove-ignore-tidy, r=alexcri…

    …chton
    
     This is a really minor issue. I noticed some tests no longer need the ignore
    tidy comment directive.
    
    A quick grep turned up the following files:
    
        src/test/compile-fail/bad-mid-path-type-params.rs
        src/test/compile-fail/bad-sized.rs
        src/test/compile-fail/coherence-default-trait-impl.rs
        src/test/compile-fail/coherence-orphan.rs
        src/test/compile-fail/issue-8767.rs
        src/test/compile-fail/lint-stability.rs
        src/test/compile-fail/lint-uppercase-variables.rs
        src/test/compile-fail/typeck-default-trait-impl-outside-crate.rs
        src/test/compile-fail/use-after-move-implicity-coerced-object.rs
        src/test/debuginfo/gdb-pretty-std.rs
    
    It didn't seem like it was worth opening an issue for this, but if that is not
    the case (i.e. it is required), I'll open one up. Thanks!
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    b389207 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    27ecaa2 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#24170 - omo:omo-typo-fix, r=steveklabnik

     Can anyone take a look? Very trivial.
    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    ce825ab View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    ede25fe View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    53a609b View commit details
    Browse the repository at this point in the history
  24. fixup windows std_misc

    Manishearth committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    ea73179 View commit details
    Browse the repository at this point in the history