Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement io::Seek on io::BufReader and io::BufWriter #24176

Merged
merged 2 commits into from
Apr 9, 2015
Merged

Implement io::Seek on io::BufReader and io::BufWriter #24176

merged 2 commits into from
Apr 9, 2015

Conversation

lilyball
Copy link
Contributor

@lilyball lilyball commented Apr 8, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Apr 8, 2015

Nice PR! Thanks @kballard.

Can you mark these impls #[unstable(feature = "buf_seek", reason = "recently added")] or something along those lines? Otherwise r=me.

@lilyball
Copy link
Contributor Author

lilyball commented Apr 9, 2015

Sure, I can do that.

@lilyball
Implement io::Seek for io::BufReader<R> where R: io::Seek
0a380a9 
Seeking the `BufReader` discards the internal buffer (and adjusts the
offset appropriately when seeking with `SeekFrom::Current(_)`).
@lilyball
Implement io::Seek for io::BufWriter<W> where W: io::Seek
1605205 
Seeking the `BufWriter` writes out its internal buffer before seeking.
@lilyball
Copy link
Contributor Author

lilyball commented Apr 9, 2015

@bors: r=aturon 1605205

@bors
Copy link
Contributor

bors commented Apr 9, 2015

⌛ Testing commit 1605205 with merge e326aa1...

bors added a commit that referenced this pull request Apr 9, 2015
@bors
Auto merge of #24176 - kballard:bufreader-seek-impl, r=aturon
e326aa1
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 9, 2015
@Manishearth
Rollup merge of rust-lang#24176 - kballard:bufreader-seek-impl, r=aturon
68100e4
@bors
Copy link
Contributor

bors commented Apr 9, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit 1605205 into rust-lang:master Apr 9, 2015
@lilyball lilyball deleted the bufreader-seek-impl branch April 11, 2015 22:39
@dtolnay dtolnay mentioned this pull request Jan 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilyball @rust-highfive @aturon @bors