fmt: impl fmt::Pointer for smart pointer types #24144
Conversation
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
This builds and does something reasonable on my machine. Is it worth adding a test? Also, are there any other smart pointer types that I should impl for? The only other one that looks relevant is |
|
Bonus impls for the other smart pointers I could find |
| @@ -276,6 +276,13 @@ impl<T: fmt::Debug + ?Sized> fmt::Debug for Box<T> { | |||
| } | |||
|
|
|||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| impl<T> fmt::Pointer for Box<T> { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | |||
| fmt::Pointer::fmt(&*self, f) | |||
There was a problem hiding this comment.
I think that this is infinitely recursive, did you mean &**self?
There was a problem hiding this comment.
Oops. Is Box specialcased in some way in the compiler? I can't seem to extract the Unique within using tuple access or a destructuring match.
expected `Box<T>`,
found `boxed::Box<_>`
(expected box,
found struct `boxed::Box`) [E0308]
/Users/richo/code/ext/rust/src/liballoc/boxed.rs:282 &Box(uniq) => fmt::Pointer::fmt(&uniq, f)
There was a problem hiding this comment.
Yeah Box is pretty special, and I'm not actually sure the definition has much bearing on what you can do with the type itself. You'll probably want to pull out &T from &Box<T> and then format that.
|
Could you add a smoke test for the |
|
Sure, I'll work out how I goofed box and add the test. |
richo
changed the title
|
I added a test, and made it pad pointers to native pointer width if no format is specified, which I bellieve to be correct. Let me know if I should rip that off though. Make check is running on my machine, but I tested that the test case added works with a stage1. |
|
(make check passes locally, on osx) |
| let old_width = f.width; | ||
| if let None = f.width { | ||
| f.width = POINTER_PADDING; | ||
| } |
There was a problem hiding this comment.
Could this change be left to another PR?
|
Rebased, this is now only the fmt::Pointer implementation |
|
Thanks! Could you also squash the commits together? Other than that r=me |
|
Done, thanks! |
~~I believe this should fix the issue. Opening a PR to ensure noone duplicates effort, I'm running check now.~~ Closes #24091
This pads out the printing of pointers to their native width. Extracted from and rebased on top of #24144
This pads out the printing of pointers to their native width. Extracted from and rebased on top of #24144
I believe this should fix the issue. Opening a PR to ensure noone duplicates effort, I'm running check now.Closes #24091