Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc: Remove ~"string" and &"string" from the language #13877

Merged
merged 3 commits into from
May 2, 2014
Merged

librustc: Remove ~"string" and &"string" from the language #13877

merged 3 commits into from
May 2, 2014

Conversation

thestinger
Copy link
Contributor

No description provided.

@bors bors closed this May 2, 2014
@bors bors merged commit e93cb04 into rust-lang:master May 2, 2014
@thestinger thestinger deleted the de-tilde-str-vec branch May 2, 2014 00:23
@huonw
Copy link
Member

huonw commented May 2, 2014

These commits should've had a [breaking-change] annotation.

renato-zannon added a commit to renato-zannon/rust-bindgen that referenced this pull request May 2, 2014
[~"string" and &"string" literals are gone](rust-lang/rust#13877), and were
replaced by "string".to_owned() and just "string", respectively. This commit was made by a simple
`sed` to convert the existing instances of ~"string" on the codebase.

For reference, the command used was this:

    sed -e 's/~\("[^"]*"\)/\1.to_owned()/g' -i *.rs

That wouldn't work if for strings that contain the `\"` escape in them, but this codebase had none.

Similar work is likely to be necessary after [~T is substituted by
Box<T>](rust-lang/rust#13885).
arcnmx pushed a commit to arcnmx/rust that referenced this pull request Jan 9, 2023
…elude, r=Veykril

fix: prefix prelude items whose name collides in current scope

Fixes rust-lang#13873

When we assemble path for prelude items whose name collides with other item in scope, we should always prefix it with module paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants