Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ~str constructors #13543

Closed
brson opened this issue Apr 16, 2014 · 7 comments
Closed

Remove ~str constructors #13543

brson opened this issue Apr 16, 2014 · 7 comments
Milestone

Comments

@brson
Copy link
Contributor

brson commented Apr 16, 2014

Per https://mail.mozilla.org/pipermail/rust-dev/2014-April/009519.html

cc #12938

Nominating.

@richo
Copy link
Contributor

richo commented Apr 16, 2014

I'm interested in helping with this as a fairly easy (read: repetitive) way to dip my toes into rust's core.

@brson brson changed the title Convert ~str to StrBuf Remove ~str constructors Apr 16, 2014
@brson
Copy link
Contributor Author

brson commented Apr 16, 2014

@richo ok! @pcwalton was planning on working on this too (but I'm sure he would appreciate help), so I suggest going in small incremental chunks to avoid clashing with each other.

I think all that has to be done here is convert everything that looks like ~"foo" to "foo".to_owned().

@brson
Copy link
Contributor Author

brson commented Apr 16, 2014

Note that I originally titled this bug incorrectly. We don't actually need to convert to StrBuf unless the code is building a string.

@richo
Copy link
Contributor

richo commented Apr 16, 2014

Ah, ok.

The first change is easy- I'll look at call sites though to see if using StrBuf makes more sense.

@richo
Copy link
Contributor

richo commented Apr 16, 2014

This looks like I can automate it pretty easily. I'll get a PR in tonight /cc @pcwalton

@brson
Copy link
Contributor Author

brson commented Apr 25, 2014

Let's also remove the language support, since DST changes the semantics.

1.0 backcompat lang.

@brson brson added this to the 1.0 milestone Apr 25, 2014
@pcwalton
Copy link
Contributor

pcwalton commented May 2, 2014

Closed by #13877!

@pcwalton pcwalton closed this as completed May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants