Fix owned string usage #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, thought I merged this already! 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Recently
~"string"literals have been removed from rust master, being replaced by"string".to_owned().The first commit is just an automatic conversion from the first form to the later, and by itself already makes the library compilable again on rust-nighly.
The second one removes multiple uses of
"string".to_owned()that were unnecessary:"string"evaluates to&'static str, which is enough most of the time, and doesn't need heap allocation. It probably won't make any significant difference on speed or memory usage, but avoiding heap allocation when possible seems to be the current best practice for idiomatic rust.