Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention me (WaffleLapkin) when changes to rustc_codegen_ssa occur #138108

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

WaffleLapkin
Copy link
Member

My employer is writing a rustc backend and it's my job to resolve conflicts with upstream so I'd like to know when rustc_codegen_ssa is being changed =)

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@WaffleLapkin
Copy link
Member Author

@bors rollup

@compiler-errors
Copy link
Member

@bors r+ rollup

(though you may be getting a lot of pings in the future lol, you can always cut down the files just to the interfaces you particularly care about)

@bors
Copy link
Contributor

bors commented Mar 6, 2025

📌 Commit 25d68f5 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Mar 6, 2025

@WaffleLapkin you probably want to edit out ur username mention in commit message, otherwise you might get pinged even in forks(?) or if some tooling includes ur commit message in PR description in random repos

And you may also want to edit @username out in PR title too for the exact same reason...

(Or just @WaffleLapkin -> WaffleLapkin)

@jieyouxu
Copy link
Member

jieyouxu commented Mar 6, 2025

I guess I can't edit the message to trigger bors
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2025
@WaffleLapkin WaffleLapkin changed the title Mention me (@WaffleLapkin) when changes to rustc_codegen_ssa occur Mention me (WaffleLapkin) when changes to rustc_codegen_ssa occur Mar 6, 2025
@WaffleLapkin WaffleLapkin force-pushed the rustc_codegen_ssa_mentions branch from 25d68f5 to 5143638 Compare March 6, 2025 18:22
@WaffleLapkin
Copy link
Member Author

I replaced direct mentions with just my username (i.e. removed the @). Thanks @jieyouxu!
@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Mar 6, 2025

📌 Commit 5143638 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
…mpiler-errors

Rollup of 17 pull requests

Successful merges:

 - rust-lang#137827 (Add timestamp to unstable feature usage metrics)
 - rust-lang#138041 (bootstrap and compiletest: Use `size_of_val` from the prelude instead of imported)
 - rust-lang#138046 (trim channel value in `get_closest_merge_commit`)
 - rust-lang#138053 (Increase the max. custom try jobs requested to `20`)
 - rust-lang#138061 (triagebot: add a `compiler_leads` ad-hoc group)
 - rust-lang#138064 (Remove - from xtensa targets cpu names)
 - rust-lang#138075 (Use final path segment for diagnostic)
 - rust-lang#138078 (Reduce the noise of bootstrap changelog warnings in --dry-run mode)
 - rust-lang#138081 (Move `yield` expressions behind their own feature gate)
 - rust-lang#138090 (`librustdoc`: flatten nested ifs)
 - rust-lang#138092 (Re-add `DynSend` and `DynSync` impls for `TyCtxt`)
 - rust-lang#138094 (a small borrowck cleanup)
 - rust-lang#138098 (Stabilize feature `const_copy_from_slice`)
 - rust-lang#138103 (Git ignore citool's target directory)
 - rust-lang#138105 (Fix broken link to Miri intrinsics in documentation)
 - rust-lang#138108 (Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur)
 - rust-lang#138117 ([llvm/PassWrapper] use `size_t` when building arg strings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9891f55 into rust-lang:master Mar 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
Rollup merge of rust-lang#138108 - WaffleLapkin:rustc_codegen_ssa_mentions, r=compiler-errors

Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur

My employer is writing a rustc backend and it's my job to resolve conflicts with upstream so I'd like to know when `rustc_codegen_ssa` is being changed =)
@WaffleLapkin WaffleLapkin deleted the rustc_codegen_ssa_mentions branch March 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants