Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triagebot: add a compiler_leads ad-hoc group #138061

Merged
merged 1 commit into from
Mar 7, 2025
Merged

triagebot: add a compiler_leads ad-hoc group #138061

merged 1 commit into from
Mar 7, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Mar 5, 2025

Intended for e.g. rolling reviewers for adding new targets.

rust-lang/rust-forge side doc update: rust-lang/rust-forge#815

r? ghost (for testing)

cc @davidtwco or @wesleywiser

@jieyouxu
triagebot: add compiler_leads ad-hoc group
9c75ed2 
Intended for e.g. rolling reviewers for adding new targets.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 5, 2025

r? compiler_leads

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2025

Failed to set assignee to compiler_leads: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 5, 2025

Hm. Maybe it takes some time to register?

Trying again:
r? compiler_leads

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2025

Failed to set assignee to compiler_leads: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@apiraino
Copy link
Contributor

apiraino commented Mar 5, 2025

r? compiler_leads

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2025

Failed to set assignee to compiler_leads: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 5, 2025 •
edited
Loading

I'm fairly sure this incantation is correct, because that's how the codegen adhoc_group works. I think this will only work once this configuration is on the master branch on this repo.

EDIT: yes, triagebot is probably reading (reasonably) triagebot.toml on master branch, not from PRs, so ofc this triagebot adhoc_group doesn't exist because I'm literally adding it right now in this PR.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 5, 2025

r? @davidtwco

@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 5, 2025

PR CI is

The hosted runner: ubuntu-24.04-16core-64gb_b4dca6406c23 lost communication with the server.

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 5, 2025

📌 Commit 9c75ed2 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2025
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Mar 6, 2025
@Noratrieb
Rollup merge of rust-lang#138061 - jieyouxu:target-reviewers, r=wesle…
49acbfc 
…ywiser

triagebot: add a `compiler_leads` ad-hoc group

Intended for e.g. rolling reviewers for [adding new targets](https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#targets).

rust-lang/rust-forge side doc update: rust-lang/rust-forge#815

r? ghost (for testing)

cc `@davidtwco` or `@wesleywiser`
@Noratrieb Noratrieb mentioned this pull request Mar 6, 2025
Closed
@compiler-errors compiler-errors mentioned this pull request Mar 6, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@bors
Auto merge of rust-lang#138127 - compiler-errors:rollup-kcarqrz, r=co…
91a0e16 
…mpiler-errors

Rollup of 17 pull requests

Successful merges:

 - rust-lang#137827 (Add timestamp to unstable feature usage metrics)
 - rust-lang#138041 (bootstrap and compiletest: Use `size_of_val` from the prelude instead of imported)
 - rust-lang#138046 (trim channel value in `get_closest_merge_commit`)
 - rust-lang#138053 (Increase the max. custom try jobs requested to `20`)
 - rust-lang#138061 (triagebot: add a `compiler_leads` ad-hoc group)
 - rust-lang#138064 (Remove - from xtensa targets cpu names)
 - rust-lang#138075 (Use final path segment for diagnostic)
 - rust-lang#138078 (Reduce the noise of bootstrap changelog warnings in --dry-run mode)
 - rust-lang#138081 (Move `yield` expressions behind their own feature gate)
 - rust-lang#138090 (`librustdoc`: flatten nested ifs)
 - rust-lang#138092 (Re-add `DynSend` and `DynSync` impls for `TyCtxt`)
 - rust-lang#138094 (a small borrowck cleanup)
 - rust-lang#138098 (Stabilize feature `const_copy_from_slice`)
 - rust-lang#138103 (Git ignore citool's target directory)
 - rust-lang#138105 (Fix broken link to Miri intrinsics in documentation)
 - rust-lang#138108 (Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur)
 - rust-lang#138117 ([llvm/PassWrapper] use `size_t` when building arg strings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5804b52 into rust-lang:master Mar 7, 2025
4 of 6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#138061
47a687e 
Rollup merge of rust-lang#138061 - jieyouxu:target-reviewers, r=wesleywiser

triagebot: add a `compiler_leads` ad-hoc group

Intended for e.g. rolling reviewers for [adding new targets](https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#targets).

rust-lang/rust-forge side doc update: rust-lang/rust-forge#815

r? ghost (for testing)

cc ``@davidtwco`` or ``@wesleywiser``
@jieyouxu jieyouxu deleted the target-reviewers branch March 7, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@davidtwco davidtwco

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jieyouxu @rustbot @apiraino @wesleywiser @bors @davidtwco